Repository navigation
Conversation
doorgan
added a commit
to expert-lsp/expert
that referenced
this pull request
Jul 1, 2026
Close #678 Fix #612 Fix #481 Ports Refactorex code into expert, under the Forge application, so we can fix issues here faster and improve expert-specific integration. This changes several pieces of code from Refactorex where we already have code for it, like diffs. It also ports the following unmerged PRs from refactorex: - gp-pereira/refactorex#37 - gp-pereira/refactorex#36 - gp-pereira/refactorex#35 - gp-pereira/refactorex#32 - gp-pereira/refactorex#34 cc @gp-pereira to review proper license attribution, there are lots of files so I followed the VSCode approach of having a THIRD_PARTY_NOTICES file and a small header on each ported file PS: apologies to reviewers for the thousand lines PRs I've been pumping lately --------- Co-authored-by: Paweł Świątkowski <katafrakt@vivaldi.net>
doorgan
added a commit
to expert-lsp/expert
that referenced
this pull request
Jul 1, 2026
Close #678 Fix #612 Fix #481 Ports Refactorex code into expert, under the Forge application, so we can fix issues here faster and improve expert-specific integration. This changes several pieces of code from Refactorex where we already have code for it, like diffs. It also ports the following unmerged PRs from refactorex: - gp-pereira/refactorex#37 - gp-pereira/refactorex#36 - gp-pereira/refactorex#35 - gp-pereira/refactorex#32 - gp-pereira/refactorex#34 cc @gp-pereira to review proper license attribution, there are lots of files so I followed the VSCode approach of having a THIRD_PARTY_NOTICES file and a small header on each ported file PS: apologies to reviewers for the thousand lines PRs I've been pumping lately (cherry picked from commit c27bf61) Co-authored-by: Paweł Świątkowski <katafrakt@vivaldi.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling Refactorex from Expert, I often see this error:
I was able to replace it by calling
outer_variableson any fragment which actually declares a variable -{:gen, _}is returned but never consumed. Swappingrecursive_analyzetoanalyze_scopehelped. Added a bunch of tests reproducing the issue.