Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prestashop] Update deployment apiVersion to 'apps/v1' - Mandatory for K8s 1.16 - #17308

Merged
k8s-ci-robot merged 1 commit into
helm:masterfrom
juan131:prestashop-apiversion
Sep 20, 2019
Merged

k8s-ci-robot merged 1 commit into
helm:masterfrom
juan131:prestashop-apiversion

Conversation

@juan131

@juan131 juan131 commented Sep 20, 2019

Copy link
Copy Markdown
Collaborator

Signed-off-by: juan131 juan@bitnami.com

What this PR does / why we need it:

There are several deprecations in the API introduced in K8s 1.16 (see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.16.md#deprecations-and-removals) which affect our manifests. The following APIs are no longer served by default:

  • All resources under apps/v1beta1 and apps/v1beta2 - use apps/v1 instead
  • daemonsets, deployments, replicasets resources under extensions/v1beta1 - use apps/v1 instead
  • networkpolicies resources under extensions/v1beta1 - use networking.k8s.io/v1 instead
  • podsecuritypolicies resources under extensions/v1beta1 - use policy/v1beta1 instead

This PR address the changes to be done for stable/prestashop.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

…tory for K8s 1.16

Signed-off-by: juan131 <juan@bitnami.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 20, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2019
@miguelaeh

Copy link
Copy Markdown
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. labels Sep 20, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan131, miguelaeh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit 92a3fdb into helm:master Sep 20, 2019
@juan131
juan131 deleted the prestashop-apiversion branch September 20, 2019 15:48
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
…tory for K8s 1.16 (helm#17308)

Signed-off-by: juan131 <juan@bitnami.com>
ali-sattari pushed a commit to ali-sattari/charts that referenced this pull request Oct 7, 2019
…tory for K8s 1.16 (helm#17308)

Signed-off-by: juan131 <juan@bitnami.com>
Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
sameersbn pushed a commit to sameersbn/kubernetes-charts that referenced this pull request Nov 8, 2019
In helm#17308 the `apiVersion` of the deployment resource was
updated to `apps/v1` in tune with the api's deprecated in k8s 1.16. This change however breaks
upgradability of existing prestashop deployments with helm v3 (rc) as described in
helm/helm#6646.

To fix this, we have defined a `prestashop.deployment.apiVersion` helper that returns the new
`apiVersion` only when k8s 1.16 or higher is in use.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
@sameersbn sameersbn mentioned this pull request Nov 8, 2019
4 tasks done
sameersbn pushed a commit to sameersbn/kubernetes-charts that referenced this pull request Nov 8, 2019
In helm#17308 the `apiVersion` of the statefulset resources was
updated to `apps/v1` in tune with the api's deprecated in k8s 1.16. This change however breaks
upgradability of existing mariadb deployments with helm v3 (rc) as described in
helm/helm#6646 and also effects any chart that uses the mariadb chart
as a dependency.

To fix this, we have defined a `mariadb.statefulset.apiVersion` helper that returns the new
`apiVersion` only when k8s 1.16 or higher is in use.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
sameersbn pushed a commit to sameersbn/kubernetes-charts that referenced this pull request Nov 8, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment).
Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker
from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place.
Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the statefulset resources was
updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion`
helper that returns the correct `apiVersion` to use depending on the k8s version

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 8, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment).
Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker
from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place.
Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In #17308 the `apiVersion` of the statefulset resources was
updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion`
helper that returns the correct `apiVersion` to use depending on the k8s version

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
sameersbn pushed a commit to sameersbn/kubernetes-charts that referenced this pull request Nov 9, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

This major version signifies this change.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
sameersbn pushed a commit to sameersbn/kubernetes-charts that referenced this pull request Nov 11, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

This major version signifies this change.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 12, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In #17308 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

This major version signifies this change.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment).
Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker
from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place.
Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the statefulset resources was
updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion`
helper that returns the correct `apiVersion` to use depending on the k8s version

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

This major version signifies this change.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment).
Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker
from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place.
Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the statefulset resources was
updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion`
helper that returns the correct `apiVersion` to use depending on the k8s version

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

This major version signifies this change.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment).
Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker
from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place.
Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the statefulset resources was
updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion`
helper that returns the correct `apiVersion` to use depending on the k8s version

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In helm#17308 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

This major version signifies this change.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants