Skip to content

test: remove redundant outside click assertions - #2146

Open
unohq[bot] wants to merge 1 commit into
mainfrom
uno/remove-outside-click-container-assertions-63
Open

unohq[bot] wants to merge 1 commit into
mainfrom
uno/remove-outside-click-container-assertions-63

Conversation

@unohq

@unohq unohq Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove four redundant HTMLElement assertions from the useOutsideClick tests
  • rely on React Testing Library's existing render().container type
  • keep test behavior unchanged

Verification

  • pnpm exec vitest run src/__tests__/useOutsideClick.spec.tsx (3 passed)
  • pnpm exec tsc --noEmit -p tsconfig.json
  • pnpm exec eslint src/__tests__/useOutsideClick.spec.tsx (0 errors, 1 pre-existing warning)
  • pnpm exec prettier --check src/__tests__/useOutsideClick.spec.tsx

@codesandbox

codesandbox Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel

vercel Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
rooks Ready Ready Preview Aug 20, 2026 7:03am

@unohq
unohq Bot marked this pull request as ready for review August 20, 2026 07:02
@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

This branch was successfully deployed

1 active deployment
Preview — 08b26fe9 Deployed Aug 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants