Skip to content

test: remove redundant outside click assertions #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unohq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: remove redundant outside click assertions #2146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/rooks/src/__tests__/useOutsideClick.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ describe("useOutsideClick", () => {
it("should trigger the calback when click on outide", () => {
expect.hasAssertions();
const { container } = render(<App />);
const app = getByTestId(container as HTMLElement, "app");
const message = getByTestId(container as HTMLElement, "message");
const app = getByTestId(container, "app");
const message = getByTestId(container, "message");
act(() => {
fireEvent.click(app);
});
Expand All @@ -130,8 +130,8 @@ describe("useOutsideClick", () => {
it("should not trigger the calback when click the volumn button (inside)", () => {
expect.hasAssertions();
const { container } = render(<App />);
const button = getByTestId(container as HTMLElement, "button");
const message = getByTestId(container as HTMLElement, "message");
const button = getByTestId(container, "button");
const message = getByTestId(container, "message");

act(() => {
fireEvent.click(button);
Expand Down
Loading