scope_map: Keep index of scopemap - #445
Closed
CohenArthur wants to merge 2 commits into
Closed
Conversation
CohenArthur
marked this pull request as draft
December 24, 2021 17:24
CohenArthur
force-pushed
the
rework-scope-map
branch
from
December 24, 2021 17:24
c2c1e63 to
cf8fafa
Compare
This change allows the scope map to keep all its scopes at all times
Member
Author
|
Maybe we could have two versions of the scope map, one keeping track of these scopes and the other one destroying them |
CohenArthur
marked this pull request as ready for review
December 25, 2021 09:37
CohenArthur
force-pushed
the
rework-scope-map
branch
from
December 25, 2021 09:38
a226e21 to
d243937
Compare
Member
Author
|
Closing for now as #448 solves the issue in a different way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the scope map to keep all its scopes at all times. I think this might not be the intended behavior, as it may fail when two functions use the same names for arguments. However, this is necessary for the generics pass to work properly.
Closes #444