Keep type in instruction - #448
Merged
Merged
Conversation
CohenArthur
force-pushed
the
keep-type-in-instruction
branch
from
December 26, 2021 18:29
4b9422f to
a1a4a73
Compare
Member
Author
|
Btw, this should also improve the speed of the typechecking pass for declarations (functions, types) |
Member
Author
|
I'm also not too happy with the name |
This was referenced Dec 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow later passes to access the type of an instruction without needing to perform the typechecking again, cache the type of each instruction in the instruction. This PR adds a lot of mutability which I am not happy with, but makes genericity possible. I have no idea how to do this without mutability or the repetition of a typechecking pass during the generic pass