Skip to content

Java bindings for mixed types as strings - #8

Merged
karthikeyann merged 5 commits into
karthikeyann:fea-json_mixed_type_as_stringfrom
andygrove:mixed-types
Dec 13, 2023
Merged

Java bindings for mixed types as strings#8
karthikeyann merged 5 commits into
karthikeyann:fea-json_mixed_type_as_stringfrom
andygrove:mixed-types

Conversation

@andygrove

Copy link
Copy Markdown

No description provided.

@karthikeyann
karthikeyann merged commit d779c07 into karthikeyann:fea-json_mixed_type_as_string Dec 13, 2023
karthikeyann pushed a commit that referenced this pull request Nov 16, 2024
Fixes call to `data_type{}` ctor in `json_test.cpp`. The 2-parameter ctor is for fixed-point-types only and will assert in a debug build if used incorrectly: https://github.com/rapidsai/cudf/blob/2db58d58b4a986c2c6fad457f291afb1609fd458/cpp/include/cudf/types.hpp#L277-L280

Partial stack trace from a gdb run
```
#5  0x000077b1530bc71b in __assert_fail_base (fmt=0x77b153271130 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n",
    assertion=0x58c3e4baaa98 "id == type_id::DECIMAL32 || id == type_id::DECIMAL64 || id == type_id::DECIMAL128",
    file=0x58c3e4baaa70 "/cudf/cpp/include/cudf/types.hpp", line=279, function=<optimized out>) at ./assert/assert.c:92
#6  0x000077b1530cde96 in __GI___assert_fail (
    assertion=0x58c3e4baaa98 "id == type_id::DECIMAL32 || id == type_id::DECIMAL64 || id == type_id::DECIMAL128",
    file=0x58c3e4baaa70 "/cudf/cpp/include/cudf/types.hpp", line=279, function=0x58c3e4baaa38 "cudf::data_type::data_type(cudf::type_id, int32_t)")
    at ./assert/assert.c:101
#7  0x000058c3e48ba594 in cudf::data_type::data_type (this=0x7fffdd3f7530, id=cudf::type_id::STRING, scale=0) at /cudf/cpp/include/cudf/types.hpp:279
#8  0x000058c3e49215d9 in JsonReaderTest_MixedTypesWithSchema_Test::TestBody (this=0x58c3e5ea13a0) at /cudf/cpp/tests/io/json/json_test.cpp:2887

```

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Karthikeyan (https://github.com/karthikeyann)
  - Muhammad Haseeb (https://github.com/mhaseeb123)

URL: NVIDIA#17273
karthikeyann pushed a commit that referenced this pull request Jul 31, 2025
As currently libcudf hides non-public symbols by default, stacktrace using C++ ABI `backtrace_symbols` no longer produces meaningful output. For example:
```
#0: gtests/STREAM_REDUCTION_TEST() [0x5bb586]
#1: gtests/STREAM_REDUCTION_TEST() [0x6a742d]
#2: gtests/STREAM_REDUCTION_TEST() [0x68a04e]
...
#8: /usr/lib64/libc.so.6 : __libc_start_main+0xe5
#9: gtests/STREAM_REDUCTION_TEST() [0x53419e]

unknown file: Failure
C++ exception with description "cudf_identify_stream_usage found unexpected stream!" thrown in the test body.
```

This PR removes completely the stacktrace generation code.

Closes NVIDIA#18831. Also closes NVIDIA#16724.

Authors:
  - Nghia Truong (https://github.com/ttnghia)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: NVIDIA#19048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants