Skip to content

Replace Windows separator with Unix separator - #20472

Merged
vmuzikar merged 3 commits into
keycloak:mainfrom
Ezreal147:main
Jul 27, 2023
Merged

Replace Windows separator with Unix separator#20472
vmuzikar merged 3 commits into
keycloak:mainfrom
Ezreal147:main

Conversation

@Ezreal147

Copy link
Copy Markdown
Contributor

Replace Windows separator with Unix separator to avoid building failure on Windows.

Closes #20471

@sschu

sschu commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

I am not sure this fix is correct. After all, quarkus.datasource.jdbc.url is a URL and URLs always have / in the path. Probably the assertion should just be rewritten to use / and not File.separator.

@stianst
stianst removed request for a team July 26, 2023 05:52
@stianst stianst self-assigned this Jul 26, 2023
Ezreal147 and others added 2 commits July 26, 2023 12:44
Replace Windows separator with Unix separator to avoid building failure on Windows.

Closes keycloak#20471
@stianst stianst removed their assignment Jul 26, 2023
@stianst stianst removed the team/core label Jul 26, 2023
@stianst stianst self-assigned this Jul 26, 2023
@vmuzikar
vmuzikar enabled auto-merge (squash) July 26, 2023 12:22
@vmuzikar
vmuzikar merged commit 5bd4d82 into keycloak:main Jul 27, 2023
mabartos pushed a commit to mabartos/keycloak that referenced this pull request Sep 15, 2023
* Replace Windows separator with Unix separator

Replace Windows separator with Unix separator to avoid building failure on Windows.

Closes keycloak#20471

* Use '/' directly instead of File.separate to then replace back to '/'

---------

Co-authored-by: Stian Thorgersen <stian@redhat.com>
vmuzikar pushed a commit that referenced this pull request Sep 19, 2023
* Keystore location does not work for Windows

Fixes #22185

* Enable Quarkus UT for Windows

Closes #23208

* Replace Windows separator with Unix separator (#20472)

* Replace Windows separator with Unix separator

Replace Windows separator with Unix separator to avoid building failure on Windows.

Closes #20471

* Use '/' directly instead of File.separate to then replace back to '/'

---------

Co-authored-by: Stian Thorgersen <stian@redhat.com>

---------

Co-authored-by: Anhanguera <1473421439@qq.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building Keycloak fails on Windows

5 participants