Skip to content

Keystore location does not work for Windows - #23284

Merged
vmuzikar merged 3 commits into
keycloak:release/22.0from
mabartos:win-22
Sep 19, 2023
Merged

Keystore location does not work for Windows#23284
vmuzikar merged 3 commits into
keycloak:release/22.0from
mabartos:win-22

Conversation

@mabartos

@mabartos mabartos commented Sep 15, 2023

Copy link
Copy Markdown
Member

Fixes #22185
Backport of #23209

mabartos and others added 3 commits September 15, 2023 11:43
* Replace Windows separator with Unix separator

Replace Windows separator with Unix separator to avoid building failure on Windows.

Closes keycloak#20471

* Use '/' directly instead of File.separate to then replace back to '/'

---------

Co-authored-by: Stian Thorgersen <stian@redhat.com>

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 15, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.VerifyProfileTest#testAttributeNotVisible

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor552.invoke(Unknown Source)
...

Report flaky test

@mabartos

Copy link
Copy Markdown
Member Author

@Pepo48 Could you please also check this PR for backporting these changes? I've also included a fix for tests 4e0b3f1, which wasn't part of the release/22.0 branch.

@Pepo48

Pepo48 commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

@mabartos I built the dist from release/22 branch with your fix included, set the scenario up and ran the dist again.

Everything worked as expected.
Thanks again, good job!

@vmuzikar
vmuzikar merged commit 7a6b8da into keycloak:release/22.0 Sep 19, 2023
@cypress

cypress Bot commented Sep 19, 2023

Copy link
Copy Markdown

Passing run #8980 ↗︎

0 527 48 0 Flakiness 0

Details:

Keystore location does not work for Windows (#23284)
Project: Keycloak Admin UI Commit: 7a6b8da229
Status: Passed Duration: 16:49 💡
Started: Sep 19, 2023 10:30 AM Ended: Sep 19, 2023 10:47 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't boot Keycloak server with Java KeyStore p12 file running on Windows 10/2019

4 participants