Skip to content

Keystore location does not work for Windows - #23209

Merged
vmuzikar merged 2 commits into
keycloak:mainfrom
mabartos:win
Sep 18, 2023
Merged

Keystore location does not work for Windows#23209
vmuzikar merged 2 commits into
keycloak:mainfrom
mabartos:win

Conversation

@mabartos

@mabartos mabartos commented Sep 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #22185
Closes #23208

Both commits are included in one PR as they would block each other.

  • Quarkus UT for Windows does not work due to the Keystore location bug.
  • We don't have any other option how to test the fix for the bug without running Quarkus UT on Windows.

I've reproduced the issue on a Win machine and the fix resolves the issue.

@mabartos mabartos self-assigned this Sep 13, 2023
@mabartos

mabartos commented Sep 13, 2023

Copy link
Copy Markdown
Member Author

Not sure what's going on for the deployment tests on Win Quarkus UT. All tests passed on testing Win machine.

@ghost ghost added the flaky-test label Sep 13, 2023
This was referenced Sep 13, 2023
Closed
Closed
Closed
Closed
ghost
ghost reviewed Sep 13, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 13, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromFile

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromHttp

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithInvalidSignatureCRL

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginWithMultipleRevocationLists

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithEmptyRevocationListFromFile

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithEmptyRevocationListFromHttp

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

@vmuzikar
vmuzikar requested a review from Pepo48 September 14, 2023 12:25
@mabartos
mabartos force-pushed the win branch 2 times, most recently from 2450a58 to e99571a Compare September 14, 2023 14:41
@mabartos

mabartos commented Sep 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

A race condition occurred inside the deployment test multiple times.
With the fix for the bug, all Quarkus UT passed (https://github.com/keycloak/keycloak/actions/runs/6186041202/job/16793326352?pr=23209)

Blocked by: #23258

EDIT: Already resolved

@mabartos
mabartos marked this pull request as ready for review September 14, 2023 14:42
@mabartos
mabartos requested review from a team as code owners September 14, 2023 14:42
@mabartos mabartos added the status/hold PR should not be merged. On hold for later. label Sep 14, 2023
ghost
ghost reviewed Sep 14, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 14, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.VerifyProfileTest#testAttributeRequiredForDefaultScope

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor553.invoke(Unknown Source)
...

Report flaky test

@mabartos mabartos removed the status/hold PR should not be merged. On hold for later. label Sep 14, 2023
@mabartos

mabartos commented Sep 14, 2023

Copy link
Copy Markdown
Member Author

@Pepo48 @vmuzikar The PR is not blocked anymore and is ready to review. Thanks :))

@mabartos mabartos mentioned this pull request Sep 15, 2023
Merged
Pepo48
Pepo48 approved these changes Sep 18, 2023
View reviewed changes

@Pepo48 Pepo48 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could reproduce the issue with the latest release (on the left) and I can also confirms that the fix works (on the right):
image

Thanks @mabartos for the fix.

@mabartos

mabartos commented Sep 18, 2023

Copy link
Copy Markdown
Member Author

@Pepo48 Thanks for the review.

@vmuzikar Are you okay with these changes?

vmuzikar
vmuzikar approved these changes Sep 18, 2023
View reviewed changes

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vmuzikar
vmuzikar merged commit c2fc2c2 into keycloak:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pepo48 Pepo48 Pepo48 approved these changes
@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@mabartos mabartos

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Quarkus UT for Windows Can't boot Keycloak server with Java KeyStore p12 file running on Windows 10/2019

3 participants

@mabartos @Pepo48 @vmuzikar