Ignore Health and Metrics artifacts - #22438
Conversation
ba25380 to
1d2d722
Compare
1d2d722 to
218460b
Compare
ahus1
left a comment
There was a problem hiding this comment.
I saw the reasons when we did this for database drivers which we excluded from the distribution and when we wanted to avoid the warnings in the log.
I am not sure about the reasons here and what benefits we're expecting from this change. Is is a shorter startup time, and less memory use? This comes with the trade-off of maintainability, as we would need to know about the transitional dependencies of those libraries.
If the benefits are not significant, I'd recommend to keep the code simpler to maintain by not implementing this change.
If the CND team still wants to merge it, I won't veto it, so that's why I just comment here.
218460b to
85a3972
Compare
|
@mabartos Could you please rebase? |
|
@vmuzikar I marked the PR as a draft as I've encountered an issue with the micrometer. Even when the feature is disabled, there's some requirement on the Quarkus side to have particular micrometer components available in the core, which is strange. I'll analyze it once it fits my TODO plan with regard to priorities. EDIT: No problems with it, caused by merging this PR: #24812 |
|
Unless there'd be a significant perf benefit in excluding these artifacts, I would not prioritize it at the moment. My 2 cents. :) |
cb9bd89 to
f119e30
Compare
|
@mabartos Could you please rebase? |
f119e30 to
6ac4368
Compare
Closes keycloak#22437 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
6ac4368 to
0b5f585
Compare
3 flaky tests on run #10181 ↗︎Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Masthead tests > Desktop view > Go to account console and back to admin console |
Test Replay
Screenshots
|
|
clients_test.spec.ts • 1 flaky test • firefox
| Test | Artifacts | |
|---|---|---|
| Clients test > Client details - Client scopes subtab > Should search non-existent client scope by name |
Screenshots
|
|
client_registration_policies.spec.ts • 1 flaky test • firefox
| Test | Artifacts | |
|---|---|---|
| Client registration policies tab > Authenticated client policies subtab > add authenticated client registration policy |
Screenshots
|
|
Review all test suite changes for PR #22438 ↗︎
Closes keycloak#22437 Signed-off-by: Martin Bartoš <mabartos@redhat.com> Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Closes #22437