Do not run value transformation if a option is being requested by its name and there is no dependency on other options - #24812
Merged
Conversation
pedroigor
force-pushed
the
issue-24757
branch
from
November 16, 2023 21:47
0a14206 to
6e0ac26
Compare
pedroigor
force-pushed
the
issue-24757
branch
from
November 16, 2023 23:40
6e0ac26 to
3623c9e
Compare
pedroigor
force-pushed
the
issue-24757
branch
from
November 17, 2023 12:35
3623c9e to
e1bff98
Compare
vmuzikar
reviewed
Nov 20, 2023
… name and there is no dependency on other options Closes keycloak#24757 Co-authored-by: Steven Hawkins <shawkins@redhat.com> Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
pedroigor
force-pushed
the
issue-24757
branch
from
November 20, 2023 11:54
e1bff98 to
f41d7ae
Compare
vmuzikar
approved these changes
Nov 21, 2023
vmuzikar
left a comment
Contributor
There was a problem hiding this comment.
@pedroigor Thanks, LGTM.
@shawkins Do you want to give it a final look too?
Contributor
Author
Contributor
|
@pedroigor no additional concerns from me. Thank you for untying this knot. |
This was referenced Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24757