Ignore JDBC Drivers artifacts - #25012
Merged
Merged
Conversation
mabartos
commented
Nov 27, 2023
Comment on lines
100
to
102
Member
Author
There was a problem hiding this comment.
Due to the changes in this PR (#24812), the transformation of values in property mappers is not executed when we want to obtain the option by its name. As that is the default behavior ATM, we can leverage the final property the option is mapped to and ensure the transformation is done.
shawkins
approved these changes
Nov 27, 2023
Closes keycloak#22442 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
vmuzikar
force-pushed
the
ignoreJdbcFix
branch
from
December 1, 2023 16:12
cd9d8a9 to
f51e1d7
Compare
vmuzikar
enabled auto-merge (squash)
December 1, 2023 16:12
This was referenced Dec 1, 2023
Closed
Closed
Passing run #10076 ↗︎Details:
Review all test suite changes for PR #25012 ↗︎ |
|||||||||||||||
ShefeeqPM
pushed a commit
to ShefeeqPM/keycloak
that referenced
this pull request
Jan 27, 2024
* Ignore JDBC Drivers artifacts (keycloak#22443) Closes keycloak#22442 Signed-off-by: Martin Bartoš <mabartos@redhat.com> * Fix obtaining removed artifacts from the configuration Signed-off-by: Martin Bartoš <mabartos@redhat.com> --------- Signed-off-by: Martin Bartoš <mabartos@redhat.com> Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22442