Decoupling legacy and dynamic user profiles and exposing metadata from admin api - #22533
Merged
Conversation
…m admin api Closes keycloak#22532 Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
1 flaky tests on run #8573 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Realm settings general tab tests > Test all general tab switches |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
jonkoops
suggested changes
Aug 21, 2023
| )} | ||
| {isUserProfileEnabled ? ( | ||
| <UserProfileFields /> | ||
| <UserProfileFields config={user?.userProfileMetadata!} /> |
Contributor
There was a problem hiding this comment.
Since the model defines userProfileMetadata as optional, I would prefer if we don't use the non-null assertion operator, as it can lead to errors around nullability, even if in this case the response might always be defined.
Contributor
There was a problem hiding this comment.
it must be defined at this point because isUserProfileEnabled is true
Co-authored-by: Jon Koops <jonkoops@gmail.com>
mposolda
approved these changes
Aug 29, 2023
jonkoops
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22532