Decoupling legacy and dynamic user profiles and exposing metadata from admin api by pedroigor · Pull Request #22790 · keycloak/keycloak

pedroigor · 2023-08-29T12:19:14Z

cypress · 2023-08-29T13:18:26Z

Passing run #8836 ↗︎

0	527	48	0	0

Details:

Merge `7b29d2a` into `2466e62`...
Project: Keycloak Admin UI	Commit: `0f80adb063 ℹ️`
Status: Passed	Duration: 17:59 💡
Started: Sep 6, 2023 12:52 PM	Ended: Sep 6, 2023 1:10 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

stianst · 2023-08-31T10:31:09Z

Not sure what's going on here, but the new store tests are taking a very long time in this PR:

Compared to latest run in release/22:

ghost · 2023-08-31T13:07:14Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnTransportLocaleTest#multipleTransports

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected SigningInPage but was Sign in to test (https://localhost:8543/auth/realms/test/login-actions/authenticate?client_id=account-console&tab_id=DDikXec_MRc)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at jdk.internal.reflect.GeneratedMethodAccessor622.invoke(Unknown Source)
...

Report flaky test

ghost

Unreported flaky test detected, please review

stianst

For some reason in this PR the following jobs consistently times out (after 90 minutes):

New Store IT (hot-rod)
New Store IT (jpa-postgres)

Latest run in release/22.0 these completed well within the timeout:

New Store IT (hot-rod): 31m
New Store IT (jpa-postgres): 38m

I have no clue what's going on, but there is something in this PR that is causing this, as I've not seen the same for runs against release/22.0 or other PRs to release/22.0.

pedroigor · 2023-09-04T11:00:26Z

@stianst Noticed the same and still trying to figure out what might be causing this.

pedroigor · 2023-09-04T11:56:14Z

@stianst Talked with @vramik and we need to backport #21828. The ZeroDowntimeTest is ignored in main and that is why the same change set works there.

vramik · 2023-09-04T12:33:27Z

@pedroigor thank you. For the context, there was a community contribution #21347 which revealed an issue during import (see details) in heterogeneous cluster which is visible in this PR as well.

The solution was split into 3 steps, disable test, introduce re-try mechanism, enable test.

We can consider backporting just #21828 or all of them.

ghost · 2023-09-04T20:38:21Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createRemoveClient

Keycloak CI - Base IT (1)

java.lang.RuntimeException: There were failures in threads. Failures count: 1
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:122)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:63)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:59)
	at org.keycloak.testsuite.admin.concurrency.ConcurrencyTest.concurrentTest(ConcurrencyTest.java:60)
...

Report flaky test

org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createClient

Keycloak CI - Base IT (1)

java.lang.RuntimeException: There were failures in threads. Failures count: 1
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:122)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:63)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:59)
	at org.keycloak.testsuite.admin.concurrency.ConcurrencyTest.concurrentTest(ConcurrencyTest.java:60)
...

Report flaky test

ghost

Unreported flaky test detected, please review

stianst

Due to updating conditional tests in release/22.0 from main the store tests no longer run against this PR, so we can't verify if the store issues are resolved.

I've opened an issue to resolve this and sent a PR for it as well:
#23001

vramik · 2023-09-06T10:00:51Z

I've prepared a backport of aforementioned #21828: #23007

…m admin api Closes keycloak#22532 Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

ghost

Unreported flaky test detected, please review

ghost · 2023-09-06T15:20:21Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

Keycloak CI - FIPS IT (strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromFile

Keycloak CI - FIPS IT (strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

ghost

Unreported flaky test detected, please review

ghost · 2023-09-06T16:23:26Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

Keycloak CI - FIPS IT (strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromFile

Keycloak CI - FIPS IT (strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.model.user.UserSyncTest#testManyUsersImport

Keycloak CI - Store Model Tests

org.keycloak.models.ModelException: org.keycloak.models.ModelException: Error creating subcontext [uid=user1,ou=People,dc=keycloak,dc=org]
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
...

Report flaky test

cypress · 2023-09-07T09:54:05Z

1 flaky test on run #8853 ↗︎

0	527	48	0	1

Details:

Decoupling legacy and dynamic user profiles and exposing metadata from admin api
Project: Keycloak Admin UI	Commit: `e88c0aa61d`
Status: Passed	Duration: 16:08 💡
Started: Sep 7, 2023 9:37 AM	Ended: Sep 7, 2023 9:54 AM

cypress/e2e/authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test		Artifacts
Authentication test > should add a condition		`Output` `Screenshots`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

pedroigor requested review from a team as code owners August 29, 2023 12:19

pedroigor requested a review from a team August 29, 2023 12:19

pedroigor requested a review from a team as a code owner August 29, 2023 12:19

ghost added team/ui team/cloud-native labels Aug 29, 2023

ahus1 approved these changes Aug 29, 2023

View reviewed changes

ahus1 enabled auto-merge (rebase) August 29, 2023 12:20

stianst force-pushed the userprofile-bp branch from 758dd43 to 548488b Compare August 31, 2023 10:31

jonkoops approved these changes Aug 31, 2023

View reviewed changes

ghost added the flaky-test label Aug 31, 2023

ghost reviewed Aug 31, 2023

View reviewed changes

pedroigor force-pushed the userprofile-bp branch 2 times, most recently from 8cb0391 to 204a5e0 Compare September 3, 2023 22:40

stianst requested changes Sep 4, 2023

View reviewed changes

pedroigor force-pushed the userprofile-bp branch from 204a5e0 to 027bdf2 Compare September 4, 2023 19:10

ghost mentioned this pull request Sep 4, 2023

Flaky test: org.keycloak.testsuite.forms.RecoveryAuthnCodesAuthenticatorTest#test03AuthenticateRecoveryAuthnCodes #22691

Closed

ghost reviewed Sep 4, 2023

View reviewed changes

pedroigor requested a review from stianst September 4, 2023 20:51

stianst mentioned this pull request Sep 6, 2023

Conditional store tests do not run if tests are updated #23001

Closed

2 tasks

stianst requested changes Sep 6, 2023

View reviewed changes

stianst mentioned this pull request Sep 6, 2023

Flaky test: org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createRemoveClient #23004

Closed

Decoupling legacy and dynamic user profiles and exposing metadata fro…

7b29d2a

…m admin api Closes keycloak#22532 Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

stianst force-pushed the userprofile-bp branch from 027bdf2 to 7b29d2a Compare September 6, 2023 11:36

stianst self-requested a review September 6, 2023 13:33

ghost reviewed Sep 6, 2023

View reviewed changes

ghost mentioned this pull request Sep 6, 2023

Flaky test: org.keycloak.testsuite.model.ConcurrentHashMapStorageTest#testStorageSeparation #22645

Closed

ghost reviewed Sep 6, 2023

View reviewed changes

stianst approved these changes Sep 7, 2023

View reviewed changes

ahus1 merged commit e88c0aa into keycloak:release/22.0 Sep 7, 2023

Uh oh!

Conversation

pedroigor commented Aug 29, 2023

Uh oh!

cypress Bot commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Passing run #8836 ↗︎

Uh oh!

stianst commented Aug 31, 2023

Uh oh!

ghost commented Aug 31, 2023

Unreported flaky test detected

org.keycloak.testsuite.webauthn.account.WebAuthnTransportLocaleTest#multipleTransports

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

stianst left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedroigor commented Sep 4, 2023

Uh oh!

pedroigor commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vramik commented Sep 4, 2023

Uh oh!

ghost commented Sep 4, 2023

Unreported flaky test detected

org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createRemoveClient

org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createClient

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

stianst left a comment

Choose a reason for hiding this comment

Uh oh!

vramik commented Sep 6, 2023

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Sep 6, 2023

Unreported flaky test detected

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromFile

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Sep 6, 2023

Unreported flaky test detected

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromFile

org.keycloak.testsuite.model.user.UserSyncTest#testManyUsersImport

Uh oh!

cypress Bot commented Sep 7, 2023

1 flaky test on run #8853 ↗︎

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cypress Bot commented Aug 29, 2023 •

edited

Loading

stianst left a comment •

edited

Loading

pedroigor commented Sep 4, 2023 •

edited

Loading