Skip to content

Status check should fail if "conditional" step fails - #22948

Merged
stianst merged 1 commit into
keycloak:mainfrom
ahus1:is-22947-status-check-fail-if-conditional-fails
Sep 5, 2023
Merged

Status check should fail if "conditional" step fails#22948
stianst merged 1 commit into
keycloak:mainfrom
ahus1:is-22947-status-check-fail-if-conditional-fails

Conversation

@ahus1

@ahus1 ahus1 commented Sep 4, 2023

Copy link
Copy Markdown
Member

Closes #22947

@ahus1 ahus1 self-assigned this Sep 4, 2023
@cypress

cypress Bot commented Sep 4, 2023

Copy link
Copy Markdown

Passing run #8801 ↗︎

0 527 48 0 Flakiness 0

Details:

Merge 710a803 into b05c79d...
Project: Keycloak Admin UI Commit: 6fd7ed40e8 ℹ️
Status: Passed Duration: 15:55 💡
Started: Sep 4, 2023 2:41 PM Ended: Sep 4, 2023 2:57 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ghost ghost added the flaky-test label Sep 4, 2023
This was referenced Sep 4, 2023
Closed
Closed
ghost
ghost reviewed Sep 4, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 4, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserLoginTest#loginWithRevalidateCertEnabledCertIsTrusted

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

org.openqa.selenium.TimeoutException: 
{"errorMessage":"URL 'https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=bec56af8-5d1b-4f1a-9e69-554ce221979d&scope=openid' didn't load. Error: 'timeout'","request":{"headers":{"Accept-Encoding":"gzip","Connection":"Keep-Alive","Content-Length":"319","Content-Type":"application/json; charset=utf-8","Host":"localhost:58070","User-Agent":"selenium/3.14.0 (java windows)"},"httpVersion":"1.1","method":"POST","post":"{\n  \"url\": \"https:\\u002f\\u002flocalhost:8543\\u002fauth\\u002frealms\\u002ftest\\u002fprotocol\\u002fopenid-connect\\u002fauth?response_type=code\\u0026client_id=test-app\\u0026redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth\\u0026state=bec56af8-5d1b-4f1a-9e69-554ce221979d\\u0026scope=openid\"\n}","url":"/url","urlParsed":{"anchor":"","query":"","file":"url","directory":"/","path":"/url","relative":"/url","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/url","queryKey":{},"chunks":["url"]},"urlOriginal":"/session/b21bd630-4b36-11ee-b953-43e965946b15/url"}}
Command duration or timeout: 0 milliseconds
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:67)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
...

Report flaky test

@ahus1
ahus1 marked this pull request as ready for review September 4, 2023 16:40
@ahus1
ahus1 requested a review from a team as a code owner September 4, 2023 16:40
@ahus1

ahus1 commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

@stianst - please have a look at this PR as you've been involved in these workflows. Once it is approved, it should IMHO be applied to the KC22 branch as well.

@ahus1
ahus1 requested a review from stianst September 4, 2023 16:42
@ahus1 ahus1 added this to the 22.0.3 milestone Sep 4, 2023
@stianst
stianst merged commit 8286b8b into keycloak:main Sep 5, 2023
stianst pushed a commit to stianst/keycloak that referenced this pull request Sep 5, 2023
@ahus1 @stianst
Status check should fail if "conditional" step fails (keycloak#22948)
7a27bae 
Closes keycloak#22947
@stianst

stianst commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

@ahus1 thanks for fixing, here's a backport #22972

stianst pushed a commit to stianst/keycloak that referenced this pull request Sep 6, 2023
@ahus1 @stianst
Status check should fail if "conditional" step fails (keycloak#22948)
7b26f71 
Closes keycloak#22947
@stianst stianst mentioned this pull request Sep 6, 2023
Closed
@ahus1 ahus1 removed this from the 22.0.3 milestone Sep 13, 2023
@ahus1
ahus1 deleted the is-22947-status-check-fail-if-conditional-fails branch September 21, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Status check succeeds if "conditional" step fails

2 participants

@ahus1 @stianst