Skip to content

Status check should fail if "conditional" step fails (#22948) - #22972

Merged
ahus1 merged 1 commit into
keycloak:release/22.0from
stianst:backport-22.0-22948
Sep 6, 2023
Merged

Status check should fail if "conditional" step fails (#22948)#22972
ahus1 merged 1 commit into
keycloak:release/22.0from
stianst:backport-22.0-22948

Conversation

@stianst

@stianst stianst commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Closes #22947

@stianst
stianst requested a review from a team as a code owner September 5, 2023 06:35
@stianst
stianst requested a review from ahus1 September 5, 2023 06:35
@stianst stianst mentioned this pull request Sep 5, 2023
Merged
@ahus1
ahus1 enabled auto-merge (squash) September 5, 2023 06:45
@cypress

cypress Bot commented Sep 5, 2023 •
edited
Loading

Copy link
Copy Markdown

Passing run #8824 ↗︎

0 527 48 0 Flakiness 0

Details:

Merge 7b26f71 into c494c60...
Project: Keycloak Admin UI Commit: cd88413500 ℹ️
Status: Passed Duration: 17:45 💡
Started: Sep 6, 2023 8:26 AM Ended: Sep 6, 2023 8:44 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ghost ghost added the flaky-test label Sep 5, 2023
@ghost ghost mentioned this pull request Sep 5, 2023
Closed
@stianst
stianst force-pushed the backport-22.0-22948 branch from 7a27bae to 7b26f71 Compare September 6, 2023 08:16
This was referenced Sep 6, 2023
Closed
Closed
ghost
ghost reviewed Sep 6, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 6, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserSyncTest#testManyUsersImport

Keycloak CI - Store Model Tests

org.keycloak.models.ModelException: org.keycloak.models.ModelException: Error creating subcontext [uid=user1,ou=People,dc=keycloak,dc=org]
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
...

Report flaky test

@ahus1
ahus1 merged commit 92754ce into keycloak:release/22.0 Sep 6, 2023
@cypress

cypress Bot commented Sep 6, 2023

Copy link
Copy Markdown

Passing run #8830 ↗︎

0 527 48 0 Flakiness 0

Details:

Status check should fail if "conditional" step fails (#22972)
Project: Keycloak Admin UI Commit: 92754cecbd
Status: Passed Duration: 17:37 💡
Started: Sep 6, 2023 9:40 AM Ended: Sep 6, 2023 9:57 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@stianst stianst mentioned this pull request Sep 11, 2023
Closed
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
@stianst
stianst deleted the backport-22.0-22948 branch July 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stianst @ahus1