Skip to content

ExternalLinksTest fails for StackApps link - #23420

Closed
mabartos wants to merge 1 commit into
keycloak:mainfrom
mabartos:KC-23386
Closed

ExternalLinksTest fails for StackApps link#23420
mabartos wants to merge 1 commit into
keycloak:mainfrom
mabartos:KC-23386

Conversation

@mabartos

@mabartos mabartos commented Sep 21, 2023

Copy link
Copy Markdown
Member

Fixes #23386

We could edit the LinkUtils class to determine whether the response code is 403 with the new ignored-link-forbidden, but I think we'd create unnecessary logic in addition.

The links for other providers are also included in the file.

@mabartos mabartos self-assigned this Sep 21, 2023
@mabartos
mabartos marked this pull request as ready for review September 21, 2023 09:37
@mabartos
mabartos requested a review from a team as a code owner September 21, 2023 09:37
@mabartos

mabartos commented Sep 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

External links check passed.

@ahus1 Could you please check it? Thanks

@mabartos
mabartos requested a review from ahus1 September 21, 2023 09:37
@ahus1

ahus1 commented Sep 21, 2023

Copy link
Copy Markdown
Member

@mabartos - this is a duplicate of #23347.

Would you mind reviewing my PR as it was created before this PR?

@mabartos

mabartos commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

Yep, sure... Sorry, I haven't noticed you've created the issue :))

@mabartos mabartos closed this Sep 21, 2023
@ghost ghost added the flaky-test label Sep 21, 2023
@ghost ghost mentioned this pull request Sep 21, 2023
Closed
ghost
ghost reviewed Sep 21, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 21, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.UpdateEmailTest#updateEmailLinkVisibleWithUpdateEmailActionEnabledAndRegistrationEmailAsUsernameAndEditUsernameNotAllowed

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/personal-info within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#applicationsTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/applications within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 Awaiting requested review from ahus1
1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@mabartos mabartos

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExternalLinksTest fails for https://stackapps.com/apps/oauth/register

2 participants

@mabartos @ahus1