Skip to content

Ignoring link for stackapps registration - #23347

Merged
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:is-23345-fix-stackapps-link
Sep 21, 2023
Merged

Ignoring link for stackapps registration#23347
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:is-23345-fix-stackapps-link

Conversation

@ahus1

@ahus1 ahus1 commented Sep 19, 2023

Copy link
Copy Markdown
Member

It now requires authentication.

Closes #23345

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 19, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.ApplicationsTest#toggleApplicationDetailsTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/applications within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

It now requires authentication.

Closes keycloak#23345
@ahus1

ahus1 commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

@mhajas - could you please review and merge this when you have the time? Thanks!

@mhajas mhajas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1

@mhajas
mhajas merged commit 5070f41 into keycloak:main Sep 21, 2023
ahus1 added a commit to ahus1/keycloak that referenced this pull request Sep 21, 2023
It now requires authentication.

Closes keycloak#23345

(cherry picked from commit 5070f41)
@ahus1
ahus1 deleted the is-23345-fix-stackapps-link branch September 21, 2023 16:55
ahus1 added a commit that referenced this pull request Oct 6, 2023
It now requires authentication.

Closes #23345

(cherry picked from commit 5070f41)
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link https://stackapps.com/apps/oauth/register

4 participants