Skip to content

Add ability to deploy js adapter to maven repository. - #23428

Closed
pskopek wants to merge 1 commit into
keycloak:release/22.0from
pskopek:backport-deploy-js-adapter-to-mvn
Closed

Add ability to deploy js adapter to maven repository.#23428
pskopek wants to merge 1 commit into
keycloak:release/22.0from
pskopek:backport-deploy-js-adapter-to-mvn

Conversation

@pskopek

@pskopek pskopek commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Closes #23312

This change will allow any downstream build to deploy keycloak-js-adapter tgz archive to maven repository by setting following properties:

  • deploy-js-to-maven-repo
  • maven.deploy.url
  • maven.repository.id

Change is set-version.sh script allows to use different version string for node package (as version string in maven and npm are not compatible).

@pskopek
Add ability to deploy js adapter to maven repository.
c2e9a41 
Closes keycloak#23312

Signed-off-by: Peter Skopek <pskopek@redhat.com>
@pskopek
pskopek requested review from a team as code owners September 21, 2023 10:17
@ghost ghost added team/ui labels Sep 21, 2023
@jonkoops

jonkoops commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Change is set-version.sh script allows to use different version string for node package (as version string in maven and npm are not compatible).

Why not only use semantic versions? These will always be compatible with both NPM and Maven.

@jonkoops jonkoops mentioned this pull request Sep 21, 2023
Closed
@pskopek pskopek mentioned this pull request Sep 21, 2023
Closed
@pskopek

pskopek commented Sep 21, 2023

Copy link
Copy Markdown
Contributor Author

See my answer here: #23425 (comment)

@ghost ghost added the flaky-test label Sep 21, 2023
@ghost ghost mentioned this pull request Sep 21, 2023
Closed
ghost
ghost reviewed Sep 21, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 21, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.ConcurrentHashMapStorageTest#testStorageSeparation

Keycloak CI - Store Model Tests

org.keycloak.models.locking.LockAcquiringTimeoutException: Lock [org.keycloak.models.RealmModel] already acquired by keycloak instance [null] at the time [null]
	at org.keycloak.models.map.lock.MapGlobalLockProvider.withLock(MapGlobalLockProvider.java:94)
	at org.keycloak.models.locking.GlobalLockProvider.withLock(GlobalLockProvider.java:45)
	at org.keycloak.models.map.storage.jpa.JpaMapStorageProviderFactory.update(JpaMapStorageProviderFactory.java:549)
	at org.keycloak.models.map.storage.jpa.JpaMapStorageProviderFactory.validateAndUpdateSchema(JpaMapStorageProviderFactory.java:471)
...

Report flaky test

@stianst

stianst commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Closing this to prevent reviewing across two different PRs, let's first figure out how we resolve this in main, then backport.

@stianst stianst closed this Sep 25, 2023
@stianst

stianst commented Sep 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

I've created a simpler proposal (at least IMO) for this here: #23512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pskopek @jonkoops @stianst