Deploy JavaScript adapter to Maven repository - #23256
Conversation
Passing run #8956 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
| <assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd"> | ||
| <id>dist</id> | ||
| <formats> | ||
| <format>zip</format> | ||
| </formats> | ||
| <includeBaseDirectory>false</includeBaseDirectory> | ||
| <fileSets> | ||
| <fileSet> | ||
| <directory>${project.basedir}/target</directory> | ||
| <outputDirectory>.</outputDirectory> | ||
| <includes> | ||
| <include>keycloak-*.tgz</include> | ||
| </includes> | ||
| </fileSet> | ||
| </fileSets> | ||
| </assembly> No newline at end of file |
There was a problem hiding this comment.
This is not needed, we should rather just attach keycloak-js-999.0.0-SNAPSHOT.tgz as it is already created by npm pack.
The format of the tgz file is explicit to support installation with npm and other package managers. For example with the new format one can do npm install keycloak-js-999.0.0-SNAPSHOT.tgz.
There was a problem hiding this comment.
Agreed, there should be no reason to re-pack this in another archive, as it is already an archive.
| <groupId>ca.szc.maven</groupId> | ||
| <artifactId>jsonpath-maven-plugin</artifactId> | ||
| <version>1.0.0</version> | ||
| <executions> | ||
| <execution> | ||
| <id>update-version</id> | ||
| <phase>process-resources</phase> | ||
| <goals> | ||
| <goal>modify</goal> | ||
| </goals> | ||
| <configuration> | ||
| <file>${basedir}/package.json</file> | ||
| <modifications> | ||
| <modification> | ||
| <expression>$.version</expression> | ||
| <value>${project.version}</value> | ||
| </modification> | ||
| </modifications> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
I'd like to rather align the way the version is set in package.json with how we're doing it already in community, which is with set-version.sh script.
This also takes care of setting versions in Maven files, containers, docs, and makes sure admin client/console uses the correct versions.
There was a problem hiding this comment.
Yes, this should be re-used if possible. Also because I believe the lockfile needs an update as well.
stianst
left a comment
There was a problem hiding this comment.
Not sure if we really should upload keycloak-js-adapter-999.0.0-SNAPSHOT.tar.gz in community releases, but guess it doesn't really hurt so okay with doing that.
|
@drichtarik One question, can PNC upload non-Maven artifacts as part of the build? It doesn't really make all that much sense for us to upload a NPM package to Maven, especially not in community. |
|
@drichtarik please don't link to RHBK issues in the community project. If anything needs changing in Keycloak upstream then open a GitHub Issue for it. |
|
closing this PR as the issue is address with newer one #23428 |
This commit adds keycloak-js-adapter.tar.gz to the list of artifacts uploaded to Maven repository
Closes #23312