added ability to have / in url#23667
Merged
jonkoops merged 5 commits intokeycloak:mainfrom Oct 17, 2023
Merged
Conversation
2 flaky tests on run #9425 ↗︎Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Clients test > Accessibility tests for clients > Check a11y violations on load/ clients list tab |
Test Replay
Output
Screenshots
|
|
realm_settings_general_tab_test.spec.ts • 1 flaky test • chrome
| Test | Artifacts | |
|---|---|---|
| Realm settings general tab tests > Test all general tab switches |
Test Replay
Output
Screenshots
|
|
Review all test suite changes for PR #23667 ↗︎
jonkoops
suggested changes
Oct 3, 2023
jonkoops
suggested changes
Oct 8, 2023
2 tasks
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Oct 16, 2023
back to having the server check this now that we have keycloak#23667 there are no issues with spaces
Contributor
|
I've moved the utility function to a dedicated file, looks like the React Router imports were causing some issues with the utility tests, this should mitigate that. |
jonkoops
approved these changes
Oct 16, 2023
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Oct 17, 2023
…#23667) Closes keycloak#22600 Co-authored-by: Jon Koops <jonkoops@gmail.com>
jonkoops
added a commit
that referenced
this pull request
Oct 17, 2023
edewit
added a commit
that referenced
this pull request
Oct 17, 2023
back to having the server check this now that we have #23667 there are no issues with spaces
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Oct 17, 2023
back to having the server check this now that we have keycloak#23667 there are no issues with spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #22600