Backport: removed invalid RealmName check (#24001) - #24065
Merged
Conversation
back to having the server check this now that we have keycloak#23667 there are no issues with spaces
jonkoops
approved these changes
Oct 17, 2023
jonkoops
enabled auto-merge (squash)
October 17, 2023 17:56
1 flaky test on run #9454 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sessions test > revocation > Check if notBefore saved |
Output
Screenshots
|
|
Review all test suite changes for PR #24065 ↗︎
2 flaky tests on run #9456 ↗︎Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication test > should add a condition |
Output
Screenshots
|
|
sessions_test.spec.ts • 1 flaky test • chrome
| Test | Artifacts | |
|---|---|---|
| Sessions test > revocation > Check if notBefore saved |
Output
Screenshots
|
|
Review all test suite changes for PR #24065 ↗︎
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
back to having the server check this
now that we have #23667 there are no issues with spaces