Fix FreeMarkerLoginFormsProvider calling handleThemeResources twice p…#49719
Merged
rmartinc merged 1 commit intoJun 9, 2026
Merged
Conversation
maeventer
force-pushed
the
fix/49718-double-handleThemeResources
branch
from
June 5, 2026 12:34
dac58e5 to
d0eb59b
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesPostTestKeycloak CI - Adapter IT Strict Cookies org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#testMultipleTabsParallelLoginKeycloak CI - Adapter IT Strict Cookies |
Contributor
|
Thanks @maeventer! I'm going to rebase your branch to include the issue about FIPS that was fixed last Friday. The change is OK for me. Let's see the tests after the rebase. |
rmartinc
force-pushed
the
fix/49718-double-handleThemeResources
branch
from
June 8, 2026 14:41
d0eb59b to
f11c206
Compare
Contributor
|
One more thing, Can you please add the signature for the commit? (you can just do |
Contributor
|
@maeventer Okis, tests pass now. So as you add the signature this is ready to go. Thanks! |
Contributor
Author
|
Great, thanks @rmartinc for taking care of it |
maeventer
force-pushed
the
fix/49718-double-handleThemeResources
branch
from
June 9, 2026 05:44
a4a4e7e to
f5c718e
Compare
…er render Signed-off-by: maeberl <markus.eberl@eventim.de>
maeventer
force-pushed
the
fix/49718-double-handleThemeResources
branch
from
June 9, 2026 05:45
f5c718e to
498b21f
Compare
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…er render (keycloak#49719) Signed-off-by: maeberl <markus.eberl@eventim.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er render
Fixes #49718
getMessage() in createCommonAttributes() internally called formatMessage(FormMessage), which re-resolved theme and locale from scratch via handleThemeResources(). This caused a redundant load of the message bundle (theme.getEnhancedMessages) and theme properties (theme.getProperties) on every login page render.
Replace getMessage() with the direct formatMessage(message, messagesBundle, locale) overload, using the already-resolved bundle and locale already available as parameters in createCommonAttributes().