Skip to content

Fix FreeMarkerLoginFormsProvider calling handleThemeResources twice per render (26.4)#51086

Open
rmartinc wants to merge 1 commit into
keycloak:release/26.4from
rmartinc:backport-49719-26.4
Open

Fix FreeMarkerLoginFormsProvider calling handleThemeResources twice per render (26.4)#51086
rmartinc wants to merge 1 commit into
keycloak:release/26.4from
rmartinc:backport-49719-26.4

Conversation

@rmartinc

@rmartinc rmartinc commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Closes #49718

PR: #49719
Commit: 7dd3fc8
PR branch: backport-49719-26.4
Target branch: https://github.com/keycloak/keycloak/tree/release/26.4

Signed-off-by: maeberl markus.eberl@eventim.de
(cherry picked from commit 7dd3fc8)

@maeventer @rmartinc
Fix FreeMarkerLoginFormsProvider calling handleThemeResources twice p…
20be6fa 
…er render (keycloak#49719)

Signed-off-by: maeberl <markus.eberl@eventim.de>
(cherry picked from commit 7dd3fc8)
@rmartinc
rmartinc requested a review from a team as a code owner July 22, 2026 11:36
@mabartos mabartos linked an issue Jul 22, 2026 that may be closed by this pull request
FreeMarkerLoginFormsProvider: handleThemeResources called twice per request due to getMessage() in createCommonAttributes #49718
Closed
2 tasks
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Jul 22, 2026
View reviewed changes

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

keycloak-github-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnTransportLocaleTest#localizationTransportUSB

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected OIDCLogin but was Account Management (https://localhost:8543/auth/realms/test/account/account-security/signing-in)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test13_registrationWithDefaultGroupsAndDeferredLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test13_registrationWithDefaultGroupsAndDeferredLdapCreation(LDAPGroupMapperTest.java:1080)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test14_registrationWithDefaultGroupsAndImmediateLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test14_registrationWithDefaultGroupsAndImmediateLdapCreation(LDAPGroupMapperTest.java:1089)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.noimport.LDAPGroupMapperNoImportTest#test13_registrationWithDefaultGroupsAndDeferredLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test13_registrationWithDefaultGroupsAndDeferredLdapCreation(LDAPGroupMapperTest.java:1080)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.noimport.LDAPGroupMapperNoImportTest#test14_registrationWithDefaultGroupsAndImmediateLdapCreation

Keycloak CI - Base IT (5)

org.keycloak.testsuite.runonserver.RunOnServerException: java.lang.NullPointerException
	at org.keycloak.testsuite.client.KeycloakTestingClient$Server.run(KeycloakTestingClient.java:201)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.configureGroupMapperAndRegistration(LDAPGroupMapperTest.java:1096)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.test14_registrationWithDefaultGroupsAndImmediateLdapCreation(LDAPGroupMapperTest.java:1089)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
@mabartos mabartos mabartos approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FreeMarkerLoginFormsProvider: handleThemeResources called twice per request due to getMessage() in createCommonAttributes

4 participants

@rmartinc @ahus1 @mabartos @maeventer