Wait for AUTH_RESPONSE page in MultipleTabsLoginTest#51103
Open
rmartinc wants to merge 1 commit into
Open
Conversation
Closes keycloak#51076 Closes keycloak#51075 Closes keycloak#51074 Closes keycloak#51073 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes multi-tab authentication tests by waiting for the client authentication response before parsing it.
Changes:
- Waits for the
AUTH_RESPONSEpage inwaitForAppPage. - Removes a redundant page-load wait.
- Simplifies a refresh callback.
This was referenced Jul 23, 2026
mabartos
approved these changes
Jul 23, 2026
| // error and being redirected to client | ||
| htmlUnitAction.run(); | ||
| } | ||
| UIUtils.currentTitleEquals("AUTH_RESPONSE"); |
Contributor
There was a problem hiding this comment.
Not a blocker, just noticed the currentTitleEquals method will return to boolean value and swallows the timeout exception. so its a wait rather than check. since we want to resolve the flaky issues, should we assert on the result with some message? LGTM otherwise also
Contributor
Author
There was a problem hiding this comment.
If it fails and returns false, we will get the error we are trying to fix. So I think that no issue. I just used this method to not create a new one that waits for the auth response page. Thanks!
gaoyikeshuer
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51076
Closes #51075
Closes #51074
Closes #51073
Add a wait for the authentication response page. This was failing in several places in the
MultipleTabsLoginTest. Don't know why this is happening now, probably some upgrade or similar. I have tested this locally and in the CI I executed both chrome and firefox 20 times each in https://github.com/rmartinc/keycloak/actions/runs/29931372085.