- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.5k
 
Fix: no indication that infinite analysis is on #13386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           I think this is superfluous as the   | 
    
| 
           @ornicar I find myself a little confused by this. It's quite late where I am, and I might be a bit sleepy.   | 
    
| 
           After giving the matter a night's rest and allowing some time for contemplation, I believe that my proposed solution or a variation thereof is a strong resolution. This is because it permits the display of   Example of   | 
    
* master: New Crowdin updates (#13302) add color field to /api/tv/channels endpoint improve sound on puzzles allow optional config values Whitelist ikmail.com (infomaniak)
| padding: 1px 3px; | ||
| text-transform: uppercase; | ||
| font-size: 11px; | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this entire block looks like a copy-paste from the .cloud block just above?
        
          
                ui/ceval/src/view.ts
              
                Outdated
          
        
      | const t: Array<VNode | string> = evs.client.cloud | ||
| ? [trans('depthX', depth), h('span.cloud', { attrs: { title: trans.noarg('cloudAnalysis') } }, 'Cloud')] | ||
| : [trans('depthX', depth + '/' + Math.max(depth, evs.client.maxDepth))]; | ||
| if (ceval.infinite()) t.push(h('span.infinite', { attrs: { title: 'infiniteAnalysis' } }, 'infinite')); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: 'infiniteAnalysis' is a raw translation key that is not being translated here
Fixes #12981
This commit addresses the issue where there was no visual indication that the infinite analysis engine is running.