Skip to content

Conversation

@ttomczak3
Copy link
Contributor

Fixes #12981
This commit addresses the issue where there was no visual indication that the infinite analysis engine is running.

Screenshot 2023-08-10 at 02-31-50 Chess analysis board

@ornicar
Copy link
Collaborator

ornicar commented Aug 10, 2023

I think this is superfluous as the 99 next to it means the same thing. A better visual indicator that the engine is running is the green bar just above. It should have the bar-anim animation.

@ttomczak3
Copy link
Contributor Author

ttomczak3 commented Aug 10, 2023

@ornicar I find myself a little confused by this. It's quite late where I am, and I might be a bit sleepy. However, isn't the 99 for Computer Analysis generally applicable? I can get a 99 even without enabling Infinite Analysis. Furthermore, the green bar is almost always animated during Computer Analysis. So, I'm wondering how the use of Infinite Analysis, indicated by the green bar, distinguishes itself from regular Computer Analysis?

@ttomczak3
Copy link
Contributor Author

After giving the matter a night's rest and allowing some time for contemplation, I believe that my proposed solution or a variation thereof is a strong resolution. This is because it permits the display of Cloud alongside Infinite aligning with the concern raised in the initial issue. However, my reservation with the 99 aspect is that it might appear even when Infinite is not enabled, albeit under the go deeper option. Although conceptually similar, this doesn't make for an effective indicator. Regarding the mentioned green bar, as previously noted, it consistently appears during computer analysis activation, which unfortunately doesn't contribute to a useful indication.

Example of Cloud alongside Infinite

image

* master:
  New Crowdin updates (#13302)
  add color field to /api/tv/channels endpoint
  improve sound on puzzles
  allow optional config values
  Whitelist ikmail.com (infomaniak)
padding: 1px 3px;
text-transform: uppercase;
font-size: 11px;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entire block looks like a copy-paste from the .cloud block just above?

const t: Array<VNode | string> = evs.client.cloud
? [trans('depthX', depth), h('span.cloud', { attrs: { title: trans.noarg('cloudAnalysis') } }, 'Cloud')]
: [trans('depthX', depth + '/' + Math.max(depth, evs.client.maxDepth))];
if (ceval.infinite()) t.push(h('span.infinite', { attrs: { title: 'infiniteAnalysis' } }, 'infinite'));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title: 'infiniteAnalysis' is a raw translation key that is not being translated here

@ornicar ornicar merged commit 30a7697 into lichess-org:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No indication that infinite analysis is running on position with high cloud eval depth

2 participants