Repository navigation
fix(i18n): restore Spanish error-message diacritics - #6999
Conversation
CLAUDE.md requires a changelog.d fragment per change instead of a direct edit to CHANGELOG.md, and this PR landed without one.
| t.t("api-error-rate-limited"), | ||
| "Límite de solicitudes excedido. Inténtelo de nuevo más tarde." | ||
| ); | ||
| } |
There was a problem hiding this comment.
spanish_translation asserts only 4 of the ~24 keys touched in errors.ftl (agent-invalid-id, session-not-found, rate-limited, plus the pre-existing agent-not-found). The corrected strings with the biggest wording changes — api-error-context-report-failed (fully reworded, not just re-accented) and api-error-manifest-signature-failed (also reworded) — have no assertion, so a future accidental revert of either wouldn't be caught here.
Not a blocker per CLAUDE.md (no hard rule mandates one assertion per Fluent key), but per the "MANDATORY … missing test coverage" review criterion this repo applies to corrected strings, worth a maintainer call on whether to round out coverage before merge or accept the sampled set as sufficient. Leaving this for human judgment rather than unilaterally expanding someone else's test to ~24 asserts.
Generated by Claude Code
houko
left a comment
There was a problem hiding this comment.
Automated daily review pass. One finding: an author-identity issue on one commit (see inline comment). Everything else checked out — see summary below.
Changelog fragment (changelog.d/fixed/6999-spanish-error-diacritics.md): correctly placed under fixed/, correct format (no leading - , one sentence per line, ends (#6999) (@houko)).
Diacritics fix (crates/librefang-types/locales/es/errors.ftl): verified valid UTF-8 throughout; all restored accented characters (á, é, í, ó, ¿) are correct Unicode code points, not mojibake or escapes. Grepped the full file for other common Spanish words missing diacritics (válido, sesión, configuración, información, técnico, etc.) — none remaining; the fix looks complete for this locale file.
Regression test (crates/librefang-types/src/i18n.rs): new assertions cover representative accented translations (api-error-agent-invalid-id, api-error-session-not-found, api-error-rate-limited).
Prose formatting: changelog fragment and code comments are one-sentence-per-line, no hard-wrap violations.
Build hygiene: no cargo build / unscoped cargo test evidence in the diff itself.
Generated by Claude Code
There was a problem hiding this comment.
Commit 9994981 ("docs(changelog): add fragment for Spanish diacritics fix") has an author identity of Claude <noreply@anthropic.com>.
The commit message text itself is clean, but CLAUDE.md's commit-msg hook separately rejects the author identity (git var GIT_AUTHOR_IDENT) when it resolves to Claude/Anthropic, independent of message content.
This will fail local commit-msg verification for anyone who has run just setup / cargo xtask setup, and violates the repo's no-AI-attribution policy even though the hook may not have been active for this push.
Recommend the author amend this commit's author (and committer) identity to their own before merge, e.g. git commit --amend --author="Name <email>" (and force-push their own branch, which is fine pre-review per CLAUDE.md).
The other commit on this branch (581e1f3, "fix(i18n): restore Spanish diacritics") is correctly attributed to Evan <tonymo2048@gmail.com>.
Generated by Claude Code
Summary
This intentionally addresses the scan finding about stripped diacritics without mixing in the much larger missing-key translation project.
Testing
cargo fmt --all -- --checkCARGO_TARGET_DIR=/tmp/librefang-sidecar-delete/target cargo test -p librefang-types i18n --libCARGO_TARGET_DIR=/tmp/librefang-sidecar-delete/target cargo clippy -p librefang-types --all-targets -- -D warningsgit diff --check