[FIRRTL] Bounce non-connect users of dropped zero-width instance ports - #11118
Open
arcusbuilds wants to merge 1 commit into
Open
arcusbuilds wants to merge 1 commit into
arcusbuilds wants to merge 1 commit into
Conversation
LowerSignatures drops zero-width ports from scalarized instances and then asserted that every remaining user of the old result was a connect. Legal consumers such as sizeof crashed the compiler (or produced invalid IR in release builds). Replace such results with a wire of the original type, mirroring the existing handling of dropped module ports. Fixes llvm#11063 Assisted-by: Claude Code:claude-fable-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LowerSignatures drops zero-width ports from scalarized instances, then asserts that every leftover user is a connect, so a legal
sizeofof such a port crashesfirtool --scalarize-internal-modules=true.Connects are still erased; any other user now reads a wire of the original type, the same way
lowerModuleSignaturealready handles dropped module ports.Test added in
lower-signatures.mlir. This is independent of #11090: LowerSignatures runs before the new LowerSizeOf pass, so the crash remains with it.Fixes #11063
Assisted-by: Claude Code:claude-fable-5