Skip to content

Remove logfire_api_session parameter from logfire.configure - #272

Merged
alexmojaki merged 3 commits into
mainfrom
alex/remove-logfire_api_session
Jun 21, 2024
Merged

alexmojaki merged 3 commits into
mainfrom
alex/remove-logfire_api_session

Conversation

@alexmojaki

Copy link
Copy Markdown
Contributor

Nothing is using this and there's no apparent use case. I think it was there for testing purposes at some point. Now it just adds bloat.

@alexmojaki
alexmojaki requested a review from Kludex June 21, 2024 12:25
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 21, 2024

Copy link
Copy Markdown

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 078576b
Status: ✅  Deploy successful!
Preview URL: https://51f399a2.logfire-docs.pages.dev
Branch Preview URL: https://alex-remove-logfire-api-sess.logfire-docs.pages.dev

View logs

@alexmojaki
alexmojaki enabled auto-merge (squash) June 21, 2024 14:40
@codecov

codecov Bot commented Jun 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexmojaki
alexmojaki merged commit 5dbfde4 into main Jun 21, 2024
@alexmojaki
alexmojaki deleted the alex/remove-logfire_api_session branch June 21, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant