Handle older versions of anthropic - #316
Merged
Merged
Conversation
alexmojaki
commented
Jul 15, 2024
| 'logfire.tags': ('LLM',), | ||
| 'duration': 1.0, | ||
| 'response_data': '{"combined_chunk_content":"The answer is secret","chunk_count":3}', | ||
| 'response_data': '{"combined_chunk_content":"The answer is secret","chunk_count":2}', |
Contributor
Author
There was a problem hiding this comment.
The more liberal checking in content_from_messages started counting an additional chunk with empty text. So I started excluding all chunks with empty text, and it turns out there was already one being counted.
Deploying logfire-docs with
|
| Latest commit: |
df20461
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a71733ca.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-old-anthropic.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
cc @willbakst |
Kludex
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #313
Ideally we'd also test on the older version in CI, but that seems like less of a priority.