Repository navigation
[v.2.4.0] Release Tracker #128436
Description
Activity
Link to landed trunk PR (if applicable):
- NA
Link to release branch PR:
- [Release 2.4] Release only changes #128347
- [Release 2.4] Release only changes - use pinned triton. #128388
- [Release 2.4] Temp change to build triton from pin builder#1863
- [Release only] use triton 3.0.x from pypi #130336
Criteria Category:
- Release only changes, temp changes to build triton from pin rather then branch
@atalman merged
- pinned this issue
on Jun 11, 2024 Link to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Required to fix rocm nightly build error AOTriton Cmake error breaking PyTorch nightly binary builds for ROCm #128420
@atalman merged
Link to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Critical fix, forward fix for Fix 'get_real_value' on placeholder nodes #127698 on release branch
@atalman merged
Link to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Reverted on main
@malfet merged
Reacted by albanDLink to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Reverted on main
@malfet merged
Reacted by albanDLink to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Reverted on main
@malfet merged
Reacted by albanDLink to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Critical fix, forward fix for Assertion error when running timm_models "levit_128" #128287 on release branch. It's a regression on inductor, will crash on many benchmark models without this fix.
@atalman merged
Reacted by albanDLink to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- (1) Fixes to regressions. In 2.4, we started spamming warnings if someone used pybind'ed functions with torch.compile. There were no such warnings in 2.3. This PR adjusts the warnings to be less spammy.
@atalman merged
Reacted by albanD48 remaining items
Link to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Fix for "libgfortran.so.5" missing error for CUDA ARM wheel at runtime
@atalman merged
Reacted by Wei WangLink to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Critical fix. Need this to avoid silent correctness for a feature not ready.
@atalman merged
Link to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
Release - Update inductor expected results after pinning numpy on torchbenchPlease note, we are in:
Phase 2 (after 7/1/24): perform extended integration/stability/performance testing based on Release Candidate builds.
We do not accept new cherry-pick requests- unpinned this issue
on Jul 11, 2024 - pinned this issue
on Jul 12, 2024 - unpinned this issue
on Jul 15, 2024 - pinned this issue
on Jul 15, 2024 Link to landed trunk PR (if applicable):
Link to release branch PR:
Criteria Category:
- Critical fixes for dependency update
@XuehaiPan This pr broke linux nightly binaries, please see here: https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/1?per_page=50&name_filter=linux- . Conda builds will require forward fix. Here is the failure: https://github.com/pytorch/pytorch/actions/runs/10036618056/job/27749407507#step:17:663 . Looks like sympy 1.13 is not available on conda: https://anaconda.org/anaconda/sympy
- unpinned this issue
on Jul 24, 2024
We cut a release branch for the 2.4.0 release.
Our plan from this point from this point is roughly:
This issue is for tracking cherry-picks to the release branch.
Cherry-Pick Criteria
Phase 1 (until 7/1/24):
Only low-risk changes may be cherry-picked from main:
Any other change requires special dispensation from the release managers (currently @atalman, @PaliC , @huydhn, @malfet). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.
Phase 2 (after 7/1/24):
Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
Changes will likely require a discussion with the larger release team over VC or Slack.
Cherry-Pick Process
Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
Create (but do not land) a PR against the release branch.
Details
Make a request below with the following format:
NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.
Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD
Versions
2.4.0