Skip to content

[dynamo] Fix for #127696 - #128358

Closed
angelayi wants to merge 1 commit into
pytorch:mainfrom
angelayi:export-D58384518
Closed

angelayi wants to merge 1 commit into
pytorch:mainfrom
angelayi:export-D58384518

Conversation

@angelayi

@angelayi angelayi commented Jun 10, 2024 •

Copy link
Copy Markdown
Contributor

@pytorch-bot

pytorch-bot Bot commented Jun 10, 2024 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128358

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4f64edd with merge base 5b5d269 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58384518

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58384518

angelayi added a commit to angelayi/pytorch that referenced this pull request Jun 10, 2024
Summary: Pull Request resolved: pytorch#128358

Test Plan:
`buck2 test @//mode/dev-nosan //executorch/exir/backend/...`
https://www.internalfb.com/intern/testinfra/testrun/12666373989243932

Differential Revision: D58384518
Summary: Pull Request resolved: pytorch#128358

Test Plan:
`buck2 test @//mode/dev-nosan //executorch/exir/backend/...`
https://www.internalfb.com/intern/testinfra/testrun/12666373989243932

Differential Revision: D58384518
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58384518

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 11, 2024
@angelayi angelayi added the topic: not user facing topic category label Jun 11, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman

atalman commented Jun 12, 2024

Copy link
Copy Markdown
Collaborator

@pytorchmergebot cherry-pick -b release/2.4

@pytorch-bot

pytorch-bot Bot commented Jun 12, 2024

Copy link
Copy Markdown

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: --onto, -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@atalman

atalman commented Jun 12, 2024

Copy link
Copy Markdown
Collaborator

@pytorchmergebot cherry-pick --onto release/2.4

@pytorch-bot

pytorch-bot Bot commented Jun 12, 2024

Copy link
Copy Markdown

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@atalman

atalman commented Jun 12, 2024

Copy link
Copy Markdown
Collaborator

@pytorchmergebot cherry-pick --onto release/2.4 -c critical

pytorchbot pushed a commit that referenced this pull request Jun 12, 2024
Test Plan:
`buck2 test @//mode/dev-nosan //executorch/exir/backend/...`
https://www.internalfb.com/intern/testinfra/testrun/12666373989243932

Differential Revision: D58384518

Pull Request resolved: #128358
Approved by: https://github.com/ydwu4

(cherry picked from commit 4345d98)
@pytorchbot

Copy link
Copy Markdown
Collaborator

Cherry picking #128358

The cherry pick PR is at #128530 and it is recommended to link a critical cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
Test Plan:
`buck2 test @//mode/dev-nosan //executorch/exir/backend/...`
https://www.internalfb.com/intern/testinfra/testrun/12666373989243932

Differential Revision: D58384518

Pull Request resolved: pytorch#128358
Approved by: https://github.com/ydwu4
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
Test Plan:
`buck2 test @//mode/dev-nosan //executorch/exir/backend/...`
https://www.internalfb.com/intern/testinfra/testrun/12666373989243932

Differential Revision: D58384518

Pull Request resolved: pytorch#128358
Approved by: https://github.com/ydwu4
atalman pushed a commit that referenced this pull request Jun 18, 2024
[dynamo] Fix for #127696 (#128358)

Test Plan:
`buck2 test @//mode/dev-nosan //executorch/exir/backend/...`
https://www.internalfb.com/intern/testinfra/testrun/12666373989243932

Differential Revision: D58384518

Pull Request resolved: #128358
Approved by: https://github.com/ydwu4

(cherry picked from commit 4345d98)

Co-authored-by: Angela Yi <angelayi@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants