Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127696
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit e0665e2 with merge base 9554300 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
BowenBao
marked this pull request as ready for review
June 2, 2024 22:56
jansel
approved these changes
Jun 6, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Pull Request resolved: #127698 Approved by: https://github.com/jansel ghstack dependencies: #127695, #127696
Contributor
|
@pytorchbot revert -m "broke (executorch?) internal tests D58295865" -c ghfirst |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit 19b31d8. Reverted #127698 on behalf of https://github.com/clee2000 due to broke (executorch?) internal tests D58295865 ([comment](#127696 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit b741819. Reverted #127696 on behalf of https://github.com/clee2000 due to broke (executorch?) internal tests D58295865 ([comment](#127696 (comment)))
Collaborator
|
@BowenBao your PR has been successfully reverted. |
Contributor
|
stacktrace Detailscc @jansel as reviewer and @digantdesai as edge oncall |
Collaborator
Author
|
Hi @clee2000, @digantdesai from stacktrace it appears an |
pytorch-bot Bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518
Contributor
angelayi
added a commit
to angelayi/pytorch
that referenced
this pull request
Jun 10, 2024
Summary: Pull Request resolved: pytorch#128358 Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518
angelayi
added a commit
to angelayi/pytorch
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: pytorch#128358 Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518 Pull Request resolved: #128358 Approved by: https://github.com/ydwu4
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Pull Request resolved: #127698 Approved by: https://github.com/jansel ghstack dependencies: #127695, #127696
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Jun 12, 2024
Summary: Fixes #124858 X-link: pytorch/pytorch#127696 Approved by: https://github.com/jansel ghstack dependencies: #127695 Reviewed By: clee2000 Differential Revision: D58443876 fbshipit-source-id: 87cccfb8ed74a6cfb3d3376b49fc84831c940c1e
pytorchbot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518 Pull Request resolved: #128358 Approved by: https://github.com/ydwu4 (cherry picked from commit 4345d98)
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
Fixes pytorch#124858 Pull Request resolved: pytorch#127696 Approved by: https://github.com/jansel ghstack dependencies: pytorch#127695
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
Pull Request resolved: pytorch#127698 Approved by: https://github.com/jansel ghstack dependencies: pytorch#127695, pytorch#127696
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
This reverts commit 19b31d8. Reverted pytorch#127698 on behalf of https://github.com/clee2000 due to broke (executorch?) internal tests D58295865 ([comment](pytorch#127696 (comment)))
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
This reverts commit b741819. Reverted pytorch#127696 on behalf of https://github.com/clee2000 due to broke (executorch?) internal tests D58295865 ([comment](pytorch#127696 (comment)))
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518 Pull Request resolved: pytorch#128358 Approved by: https://github.com/ydwu4
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
Fixes pytorch#124858 Pull Request resolved: pytorch#127696 Approved by: https://github.com/jansel ghstack dependencies: pytorch#127695
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
Pull Request resolved: pytorch#127698 Approved by: https://github.com/jansel ghstack dependencies: pytorch#127695, pytorch#127696
ignaciobartol
pushed a commit
to ignaciobartol/pytorch
that referenced
this pull request
Jun 14, 2024
Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518 Pull Request resolved: pytorch#128358 Approved by: https://github.com/ydwu4
ignaciobartol
pushed a commit
to ignaciobartol/pytorch
that referenced
this pull request
Jun 14, 2024
Fixes pytorch#124858 Pull Request resolved: pytorch#127696 Approved by: https://github.com/jansel ghstack dependencies: pytorch#127695
ignaciobartol
pushed a commit
to ignaciobartol/pytorch
that referenced
this pull request
Jun 14, 2024
Pull Request resolved: pytorch#127698 Approved by: https://github.com/jansel ghstack dependencies: pytorch#127695, pytorch#127696
atalman
pushed a commit
that referenced
this pull request
Jun 18, 2024
[dynamo] Fix for #127696 (#128358) Test Plan: `buck2 test @//mode/dev-nosan //executorch/exir/backend/...` https://www.internalfb.com/intern/testinfra/testrun/12666373989243932 Differential Revision: D58384518 Pull Request resolved: #128358 Approved by: https://github.com/ydwu4 (cherry picked from commit 4345d98) Co-authored-by: Angela Yi <angelayi@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #124858
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang