Make sdl2 platform compatible with apple silicon#5
Merged
logicplace merged 4 commits intoMar 11, 2026
Merged
Conversation
Mac doesn't support fopen64, ftello64, or fseeko64, so use the supported version
Contributor
|
Looks good! If you figure out the fixes for the dev build it can be a separate PR, I'll go ahead and merge this one. |
Contributor
Author
|
PR #6 should get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
large file handling
Mac doesn't (seem to) support
fopen64,ftello64, orfseeko64, so use#defineto switch to the supported versions (fopen,ftello, andfseeko).There's a stackoverflow answer https://stackoverflow.com/questions/4003479/how-to-enable-large-file-support-under-darwin that claims that this code should just use
fopen/ftello/fseekoby default instead of the large filefWHATEVER64versions, so it would be easy modify this PR to switch all instance offWHATEVER64tofWHATEVER.makefile
Use rm -rf on all created files instead of rmdir --ignore-fail-on-non-empty Build
strcpy->memmove
I was getting
SIGTRACEs because thestrs in thestrcpyoperations had overlap andmemmoveis safer.