Tweak debug platform to work on macos#6
Draft
pkingstonxyz wants to merge 2 commits into
Draft
Conversation
The SDL event loop seemed to be starving the gtk event loop of event, swapping them around allows for proper event handling and the application to function
pkingstonxyz
marked this pull request as draft
March 12, 2026 10:45
Contributor
Author
Going to treat this as something of a devlog becuase I saw this PR mentioned on the pokemon mini website.
Argument for SDL3I'm using SDL3+DearImGui instead of the existing SDl2 build becuase I'd like an emscripten web platform and, by going from the ground up with SDL3 callback functions, making it web compatible will be much easier than ripping out and re-architecting the necessary data/variables for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makefile
Use
rm -rfwhen themaketarget iscleaninstead of-rmdir --ignore-fail-on-non-empty $(BUILD)GTK vs SDL event loop
The SDL event loop wasn't properly routing the user interaction events to the GTK event loop, but GTK does send events to SDL. Some stackoverflow posts indicate that there's probably a more robust way to handle this, but 'werks on my machine' as they say.