forked from vmangos/core
-
Notifications
You must be signed in to change notification settings - Fork 1
Repack 23 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Repack 23 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct comment position * Enable self-resurrection spells for 1.5 client Fixes build errors related to self-resurrection and enables self- resurrection to work on the 1.5 client, per the 1.6 patch notes. > Self-resurrection spells show their name on the button in the release > spirit dialog. The update field PLAYER_SELF_RES_SPELL did not exist in patch 1.5, and so the ID of the self-resurrection spell was not sent to the client. Decompiled 1.5 client code shows that it instead checks the player flag 0x1000 (currently PLAYER_FLAGS_PARTIAL_PLAY_TIME) to determine whether the player can self-resurrect, meaning this flag was repurposed on or after patch 1.6. As this means we cannot store the spell ID in the player's update fields, for these clients we instead store the ID purely server-side to read after the player dies.
information from Daribon: windows build curently failing in actions since openssl can't be found it now installs it at C:\Program Files\OpenSSL-Win64\ while it tries to find it in C:\Program Files\OpenSSL\
* Fix gossip menu options for client version 1.5 Decompiled 1.5 client code shows that... 1. The icon is read as a 32-bit integer instead of 8-bit. 2. The "coded" field is not read at all, indicating that that field was added in patch 1.6. This lines up with the Blue Murloc Egg being likely the first item obtainable by gossip-code in late 2005. Before this change, opening a gossip menu with options would crash the client. * Correct version check style
Before patch 1.7, Orb of Deception was applied as a Dummy aura instead of a Transform aura. Otherwise the spell is nearly identical, so we simply reuse the existing Transform aura handling.
Should fix AV becoming totally broken after running for multiple days.
choco package changes the openssl way too often, we should just use our internal openssl
Closes #2340
It's already generated and set as the entry of the ObjectGuid in CreateBaseAtCreature. Thanks to celguar for noticing this.
Also remove useless checks for null session. It can never be null! Closes #2374
Part of #1970
Closes #791
It was weirdly teleporting to a proximate location based on boundingradius and conserving teleported player orientation. Much more convenient for testing and gm activity to teleport to accurate pos
On official servers if you get invited to a group while already in an instance, that save persists through logout while grouped, even though its a personal save. If there is no group save created yet, it will persist through leaving and entering the dungeon as well. Its only reset once you exit the dungeon when there already is a group save.
Only for those not currently inside their personal saves.
The database values based on classic sniffs are completely fine.
In classic you get an error message and it doesn't let you cast it, instead of casting it and causing flag to drop. The attribute that I believe controls this was only added to immunity spells in patch 1.9, so that would indicate it was possible to bop people to make them drop flag in early vanilla.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Proof
Issues
How2Test
Todo / Checklist