Skip to content

Fix a bug with no-treeshake - #639

Merged
Victorystick merged 3 commits into
rollup:masterfrom
Victorystick:fix-no-treeshake-vars
May 3, 2016
Merged

Fix a bug with no-treeshake#639
Victorystick merged 3 commits into
rollup:masterfrom
Victorystick:fix-no-treeshake-vars

Conversation

@Victorystick

@Victorystick Victorystick commented May 2, 2016

Copy link
Copy Markdown
Contributor

When multiple variables were exported through the same named export declaration, there was a bug where Rollup generated multiple var keywords. For example,

export var a = 1, b = 2;

became

var var a = 1;
var b = 2;

export { a, b };

This PR addresses this issue, resulting in the expected

var a = 1;
var b = 2;

export { a, b };

@Victorystick
Victorystick merged commit 126b22c into rollup:master May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant