Skip to content

Fix a bug with no-treeshake #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Victorystick merged 3 commits into from
May 3, 2016
Merged

Fix a bug with no-treeshake #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1286d3
Add failing test case, which results in "var var ..."
Victorystick May 2, 2016
fbb0b39
Fix failing test
Victorystick May 2, 2016
610f798
Missing trailing new-lines
Victorystick May 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ export default class Module {
run ( treeshake ) {
if ( !treeshake ) {
this.statements.forEach( statement => {
if ( statement.isImportDeclaration ) return;
if ( statement.isImportDeclaration || ( statement.isExportDeclaration && statement.node.isSynthetic ) ) return;

statement.mark();
});
Expand Down
5 changes: 5 additions & 0 deletions test/form/no-treeshake/_expected/amd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ define(['exports', 'external'], function (exports, external) { 'use strict';
return 13 + external.value;
}

var create = Object.create;
var getPrototypeOf = Object.getPrototypeOf;

exports.baz = baz;
exports.create = create;
exports.getPrototypeOf = getPrototypeOf;
exports.strange = quux;

});
5 changes: 5 additions & 0 deletions test/form/no-treeshake/_expected/cjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,10 @@ function baz () {
return 13 + external.value;
}

var create = Object.create;
var getPrototypeOf = Object.getPrototypeOf;

exports.baz = baz;
exports.create = create;
exports.getPrototypeOf = getPrototypeOf;
exports.strange = quux;
5 changes: 4 additions & 1 deletion test/form/no-treeshake/_expected/es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,7 @@ function baz () {
return 13 + external.value;
}

export { baz, quux as strange };
var create = Object.create;
var getPrototypeOf = Object.getPrototypeOf;

export { baz, create, getPrototypeOf, quux as strange };
5 changes: 5 additions & 0 deletions test/form/no-treeshake/_expected/iife.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@
return 13 + external.value;
}

var create = Object.create;
var getPrototypeOf = Object.getPrototypeOf;

exports.baz = baz;
exports.create = create;
exports.getPrototypeOf = getPrototypeOf;
exports.strange = quux;

}((this.stirred = this.stirred || {}),external));
5 changes: 5 additions & 0 deletions test/form/no-treeshake/_expected/umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@
return 13 + external.value;
}

var create = Object.create;
var getPrototypeOf = Object.getPrototypeOf;

exports.baz = baz;
exports.create = create;
exports.getPrototypeOf = getPrototypeOf;
exports.strange = quux;

}));
2 changes: 2 additions & 0 deletions test/form/no-treeshake/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ function bar () {
export function baz () {
return 13 + external.value;
}

export var create = Object.create, getPrototypeOf = Object.getPrototypeOf;