Skip to content

refactor(interp): share the native call return-kind check - #194

Closed
siyul-park wants to merge 1 commit into
fix/jit-return-retain-orderingfrom
refactor/jit-check-returns
Closed

siyul-park wants to merge 1 commit into
fix/jit-return-retain-orderingfrom
refactor/jit-check-returns

Conversation

@siyul-park

Copy link
Copy Markdown
Owner

Split out of #191. Stacked on #193.

directCall and selfCall each carried their own copy of the switch listing the return kinds a native call can hand back in registers — the same six kinds, in a different order. Extracted as checkReturns so the two paths cannot drift, and so widening the set is one edit rather than two.

No behavior change: the two switches accepted identical kind sets.

Test plan

  • go test -race ./interp/... ./asm/...
  • make lint, make check-generated

Refs #164

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d310bb7-3f97-47e4-b10d-381fbba966ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

directCall and selfCall each carried their own copy of the switch listing the
return kinds a native call can hand back in registers - the same six kinds in
a different order. Extract checkReturns so the two paths cannot drift, and so
widening the set later is one edit rather than two.

No behavior change: the two switches accepted identical kind sets.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@siyul-park
siyul-park force-pushed the refactor/jit-check-returns branch from cc8fcec to 37aff98 Compare August 16, 2026 00:48
@siyul-park
siyul-park deleted the branch fix/jit-return-retain-ordering August 16, 2026 00:57
@siyul-park siyul-park closed this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant