Skip to content

refactor(interp): share the native call return-kind check - #196

Merged
siyul-park merged 1 commit into
mainfrom
refactor/jit-check-returns
Aug 16, 2026
Merged

siyul-park merged 1 commit into
mainfrom
refactor/jit-check-returns

Conversation

@siyul-park

Copy link
Copy Markdown
Owner

Replaces #194, which GitHub auto-closed and refused to reopen when its base branch (#193) was deleted on merge. Same content.

directCall and selfCall each carried their own copy of the switch listing the return kinds a native call can hand back in registers — the same six kinds, in a different order. Extracted as checkReturns so the two paths cannot drift, and so widening the set is one edit rather than two.

No behavior change: the two switches accepted identical kind sets.

Test plan

  • go test -race ./interp/... ./asm/...
  • make lint, make check-generated

Refs #164

🤖 Generated with Claude Code

directCall and selfCall each carried their own copy of the switch listing the
return kinds a native call can hand back in registers - the same six kinds in
a different order. Extract checkReturns so the two paths cannot drift, and so
widening the set later is one edit rather than two.

No behavior change: the two switches accepted identical kind sets.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@siyul-park, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e829ab9-9c3b-4772-ab85-cfad2c3bd79c

📥 Commits

Reviewing files that changed from the base of the PR and between 06c8152 and 0d95c33.

📒 Files selected for processing (1)
  • interp/jit_arm64.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@siyul-park
siyul-park merged commit 89ed306 into main Aug 16, 2026
3 checks passed
@siyul-park
siyul-park deleted the refactor/jit-check-returns branch August 16, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant