Repository navigation
refactor(interp): share the native call return-kind check - #196
Conversation
directCall and selfCall each carried their own copy of the switch listing the return kinds a native call can hand back in registers - the same six kinds in a different order. Extract checkReturns so the two paths cannot drift, and so widening the set later is one edit rather than two. No behavior change: the two switches accepted identical kind sets. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 35 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replaces #194, which GitHub auto-closed and refused to reopen when its base branch (#193) was deleted on merge. Same content.
directCallandselfCalleach carried their own copy of the switch listing the return kinds a native call can hand back in registers — the same six kinds, in a different order. Extracted ascheckReturnsso the two paths cannot drift, and so widening the set is one edit rather than two.No behavior change: the two switches accepted identical kind sets.
Test plan
go test -race ./interp/... ./asm/...make lint,make check-generatedRefs #164
🤖 Generated with Claude Code