Upgrade formatter to clang-format-11#734
Merged
Merged
Conversation
nrabinowitz
approved these changes
Dec 6, 2022
dfellis
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI in #733 is failing due to an upgrade of Github Actions CI from Ubuntu Focal to Ubuntu Jammy. clang-format-9 is no longer available in Jammy. (https://packages.ubuntu.com/focal/clang-format-9 vs https://packages.ubuntu.com/jammy/clang-format-9) It seems the lowest version of clang-format in Jammy is clang-format-11, which was released about a year after clang-format-9, in October 2022. I propose we upgrade our standard formatter from 9 to 11.
It turns out I have already been formatting code with clang-format-14 so I don't think there will be any formatting change.