Repository navigation
Surface EnableCSI requirement for snapshot-move-data backups - #10355
Open
PranjalManhgaye wants to merge 3 commits into
Open
PranjalManhgaye wants to merge 3 commits into
PranjalManhgaye wants to merge 3 commits into
Conversation
When snapshot-move-data is requested but EnableCSI is off, warn operators explicitly and record the skipped PV reason instead of reporting a generic volumesnapshotter failure. Fixes velero-io#10299 Signed-off-by: PranjalManhgaye <manhgayepranjal@gmail.com>
👷 Deploy request for velero pending review.Visit the deploys page to approve it
|
Signed-off-by: PranjalManhgaye <manhgayepranjal@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Cover the non-snapshot-move-data CSI BIA skip path and the snapshot-move-data fallback path when EnableCSI is enabled. Signed-off-by: PranjalManhgaye <manhgayepranjal@gmail.com>
kaovilai
approved these changes
Sep 25, 2026
kaovilai
left a comment
Member
There was a problem hiding this comment.
LGTM on the code — clear improvement: when snapshot-move-data is requested but EnableCSI isn't set, this now logs a specific warning and tracks the PV as skipped with a clear reason, instead of a generic silent skip. Well covered with new test cases for the EnableCSI on/off x snapshot-move-data interaction. Has changelog and unit tests.
Note: PR currently shows mergeable=CONFLICTING — will need a rebase before it can land.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10299
Summary
Test plan
go test ./pkg/backup -run 'TestBackupItemActionsForSkippedPV|TestBackupWithSnapshots'