Repository navigation
fix: bound VolumeSnapshot and VolumeSnapshotContent error retry by CSISnapshotTimeout - #10493
Open
webdevsamran wants to merge 2 commits into
Open
webdevsamran wants to merge 2 commits into
webdevsamran wants to merge 2 commits into
Conversation
…ISnapshotTimeout Progress() in pkg/backup/actions/csi/volumesnapshot_action.go previously treated VolumeSnapshotContent errors as terminal on first sight, causing immediate backup failures when external snapshot controllers recorded retryable provider errors (such as SnapshotCreationPerVolumeRateExceeded). VolumeSnapshot errors were also treated as unconditionally temporary. This change aligns both VolumeSnapshot and VolumeSnapshotContent error handling to permit retries within backup.Spec.CSISnapshotTimeout, failing only once the error persists beyond that duration. Fixes velero-io#10483 Signed-off-by: Samran Asif <samranwebdev2000@gmail.com>
✅ Deploy Preview for velero ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kaovilai
previously approved these changes
Sep 25, 2026
kaovilai
left a comment
Member
There was a problem hiding this comment.
LGTM — bounds VolumeSnapshot/VSC error retry by CSISnapshotTimeout, preventing unbounded retry loops. Has unit tests and changelog, CI green.
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
In
pkg/backup/actions/csi/volumesnapshot_action.go,Progress()previously treatedVolumeSnapshotContenterrors (vsc.Status.Error != nil) as terminal failures on first sight (markingprogress.Completed = trueandprogress.Err = *vsc.Status.Error.Message), causing immediate backup failure (PartiallyFailed) when the external snapshotter controller encountered retryable provider errors (such as AWSSnapshotCreationPerVolumeRateExceeded). Conversely,VolumeSnapshoterrors (vs.Status.Error != nil) were unconditionally treated as temporary, allowing them to hang untilitemOperationTimeout(4 hours).This PR brings consistent, symmetrical error handling to both
VolumeSnapshotandVolumeSnapshotContent:vsc.Status.Error != niloccurs within the configuredbackup.Spec.CSISnapshotTimeout, Velero logs a warning and allows the external snapshotter controller to retry instead of terminating immediately.vs.Status.Errororvsc.Status.Errorpersists beyondbackup.Spec.CSISnapshotTimeout, Velero marks the operation failed with a descriptive error message, failing early rather than hanging untilItemOperationTimeout.VolumeSnapshotandVolumeSnapshotContent.changelogs/unreleased/10483-webdevsamran.Does your change fix a particular issue?
Fixes #10483
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.