remove interaction between encoding.active and simulcast ~rid - #2754
Merged
Conversation
since this would imply setParameters can trigger changes to the SDP that require negotiation. Applications that rely on this behavior can still inspect the SDP (or rely on other means of signaling) and manually change the encodings active property to not send a particular encoding. Fixes w3c#2735
Contributor
Author
|
@docfaraday can you take a look, also at the test in web-platform-tests/wpt#34912 |
jan-ivar
reviewed
Jul 20, 2022
jan-ivar
approved these changes
Jul 20, 2022
Contributor
|
@dontcallmedom Travis came down with COVID, so may be a bit slow adding @fippo to the list of contributors. |
aboba
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since this would imply setParameters can trigger changes to the
SDP that require negotiation.
Applications that rely on this behavior can still inspect the SDP
(or rely on other means of signaling) and manually change the
encodings active property to not send a particular encoding.
Fixes #2735
Preview | Diff