webrtc: add test assertions for simulcast-~ spec change - #34912
Merged
Conversation
wpt-pr-bot
requested review from
alvestrand,
guidou,
henbos,
jan-ivar,
rwaldron,
snuggs and
youennf
July 20, 2022 12:27
Contributor
Author
|
spec change in w3c/webrtc-pc#2754 |
jan-ivar
approved these changes
Jul 20, 2022
jan-ivar
left a comment
Member
There was a problem hiding this comment.
Looks good, but should some of these perhaps be in simulcast-offer.html instead?
I ask because I'd like to reference them in w3c/webrtc-pc#2755.
fippo
force-pushed
the
webrtc-simulcast-tilde
branch
from
July 20, 2022 19:49
c5872b6 to
2851816
Compare
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Contributor
Author
|
the -offer path is a bit more complicated sadly :-( |
Contributor
|
Test failure in STP happens with and without the changes so good to go. |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see w3c/webrtc-pc#2735