Skip to content

BREAKING CHANGE: remove platform from ManifestImageResource - #913

Merged
marcoscaceres merged 1 commit into
gh-pagesfrom
drop-image-resource-platform
Jul 6, 2020
Merged

BREAKING CHANGE: remove platform from ManifestImageResource#913
marcoscaceres merged 1 commit into
gh-pagesfrom
drop-image-resource-platform

Conversation

@christianliebel

@christianliebel christianliebel commented Jul 6, 2020

Copy link
Copy Markdown
Member

Closes #909

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

  • Safari (not implemented)
  • Chrome (not implemented)
  • Firefox (not implemented)
  • Edge (not implemented)

Commit message:

As pointed out in #909, the manifest provides other ways to adapt to platform conventions without explicitly stating a platform. Additionally, the property was never implemented by any browser.


Preview | Diff

@christianliebel christianliebel added the breaking Use for changes that break existing normative behavior label Jul 6, 2020
@christianliebel
christianliebel force-pushed the drop-image-resource-platform branch 2 times, most recently from be4cf88 to 42fa7fe Compare July 6, 2020 08:17

@marcoscaceres marcoscaceres left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As pointed out in #909, the manifest provides other ways to adapt to platform conventions without explicitly stating a platform. Additionally, the property was never implemented by any browser.
@christianliebel
christianliebel force-pushed the drop-image-resource-platform branch from 42fa7fe to d856bc6 Compare July 6, 2020 08:22
@marcoscaceres
marcoscaceres merged commit 4ab46a2 into gh-pages Jul 6, 2020
@christianliebel
christianliebel deleted the drop-image-resource-platform branch July 6, 2020 12:23
@mgiuca

mgiuca commented Jul 8, 2020

Copy link
Copy Markdown
Collaborator

Great, retroactive +1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Use for changes that break existing normative behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

At risk: ManifestImageResource.platform?

3 participants