Repository navigation
fix: validate integer range and address padding in AbiParameters.decode - #558
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Published pnpm add ox@pr-558
pnpm add ox@0.0.0-pr-558-2486418 |
Merged
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports wevm/viem#5359 (by @haybinalim, fixes wevm/viem#5350) to Ox.
AbiParameters.decoderead the full 32-byte word forintN/uintNwithout checking it against the declared size, and ignored the high 12 bytes ofaddresswords, so malformed data decoded to values the type can't hold (e.g.uint80x…0100→256,int80x…0080→128).decodeNumber: decodes the word as a 256-bit bigint and, below 256 bits, checks it against the type's[min, max], throwingHex.IntegerOutOfRangeError(the same errorencodethrows). Sizes ≤ 48 still returnnumber.decodeAddress: requires the 12 padding bytes to be zero, throwingAddress.InvalidAddressError(causeAddress.InvalidInputError).This matches Solidity 0.8
abi.decodeand eth_abi. Both errors were already on the adversarial-fuzz allow-list.Tests: new cases in
AbiParameters.decode.test.ts(9 fail on main, pass here, including a min/max/out-of-range sweep over everyuint8…uint256/int8…int256); fullcoreproject passes apart from network-dependent tests; ABI fuzz suites andtsc -bpass.