Skip to content

fix: validate integer range and address padding in AbiParameters.decode [0.x] - #559

Merged
jxom merged 1 commit into
0.xfrom
fix/decode-abi-integer-range-0.x
Nov 1, 2026
Merged

jxom merged 1 commit into
0.xfrom
fix/decode-abi-integer-range-0.x

Conversation

@jxom

@jxom jxom commented Nov 1, 2026

Copy link
Copy Markdown
Member

Backport of wevm/ox#558 to 0.x; ports wevm/viem#5359 (by @haybinalim, fixes wevm/viem#5350).

AbiParameters.decode now rejects intN/uintN words outside the declared type's range (Hex.IntegerOutOfRangeError) and address words with non-zero high padding (Address.InvalidAddressError), matching Solidity 0.8 abi.decode and eth_abi. Same source change as #558; only the test file's imports differ (vitest on 0.x).

Tests: new cases in AbiParameters.decode.test.ts pass; tsc --noEmit and Biome pass; the rest of the core project passes apart from network-dependent tests that fail the same way on a clean 0.x in this environment.

@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ox Ready Ready Preview Nov 1, 2026 9:55am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T09:47:48.178907Z 94634e2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Published ox@0.0.0-pr-559-94634e2 under the pr-559 dist-tag, which follows this pull request until it closes.

pnpm add ox@pr-559
pnpm add ox@0.0.0-pr-559-94634e2

@jxom
jxom merged commit 4f5a87a into 0.x Nov 1, 2026
14 checks passed
@jxom
jxom deleted the fix/decode-abi-integer-range-0.x branch November 1, 2026 09:57
@github-actions github-actions Bot mentioned this pull request Nov 1, 2026

This branch was successfully deployed

1 active deployment
Preview — 94634e25 Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant